Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When a script extends from a class with a custom icon, the base class icon is used instead #24657

Closed
PLyczkowski opened this issue Dec 29, 2018 · 3 comments · Fixed by #25676
Closed

Comments

@PLyczkowski
Copy link

My expectation would be that when extending from a class, it would show the class icon, not the base class icon.
In a similar fashion, when extending from a class with a custom icon, and naming the new class with class_name and providing a path to new icon, no icon is used at all - I would expect the new icon path to be used in that case (always to 'topmost' one).

Usecase:
shot_181229_163633

I use custom classes for Effects and EffectComponents. EffectComponents are usually extended, with some added functionality - I then lose the benefits of custom icons (which, when they work, are awesome : )

@willnationsdev

@willnationsdev
Copy link
Contributor

This is likely a matter of EditorNode::get_object_icon and/or EditorNode::get_class_icon not performing an inheritance loop check for any inherited icons in the case that one is not found.

@willnationsdev
Copy link
Contributor

@PLyczkowski Was this using a CustomType or a Script Class?

@PLyczkowski
Copy link
Author

PLyczkowski commented Dec 31, 2018

This is using the class_name keyword, with a path to icon

The named class extended from Node

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants