Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement NodePath drag and drop in remote scene tree #23768

Closed
Tracked by #47369
Jummit opened this issue Nov 17, 2018 · 5 comments · Fixed by #56063
Closed
Tracked by #47369

Implement NodePath drag and drop in remote scene tree #23768

Jummit opened this issue Nov 17, 2018 · 5 comments · Fixed by #56063

Comments

@Jummit
Copy link
Contributor

Jummit commented Nov 17, 2018

Since the local and remote tab of the scene view are very similar I found myself wanting to drag a node path from the remote scene into my script, which of course does not work (yet).

@akien-mga akien-mga changed the title [Enhancement] Node path drag and drop in remote scenetree Node path drag and drop in remote scenetree Nov 17, 2018
@KoBeWi
Copy link
Member

KoBeWi commented Oct 15, 2019

There's new "Copy Path" option for remote tree in 3.2, so implementing drag and drop is a combination of what local tree already does and that new option.

@Arunkumar1998BOM
Copy link

Arunkumar1998BOM commented Nov 6, 2019

@KoBeWi
I will work on this,
I need the following:
1.) Steps to reproduce the issue
2.) References I can check to understand the drag&drop thing
3.) Files which reference the local and remote tabs (or its okay, ill figure it out myself)
4.) References I can take (if any issues addressing these files or functionality was pushed)

@KoBeWi
Copy link
Member

KoBeWi commented Nov 6, 2019

Eh, I don't think you need reproduction project/steps here. Just read the OP.

As for references, here's the PR that implemented Copy Path for remote tree #28905
(the drag and drop feature might be located somewhere in SceneTreeEditor/Dock or whatever the file was called)

@Arunkumar1998BOM
Copy link

I am sorry, what I meant was, I exactly dont know how you can pull the node path and drop in remote scenetree node. I actually do not know where you can find node path and remote scenetree as I am new to the codebase as well as the editor and am learning. I can go through docs which will take lot of time. Instead, A snap of editor or steps would be useful.

@KoBeWi
Copy link
Member

KoBeWi commented Nov 6, 2019

https://docs.godotengine.org/en/3.1/tutorials/debug/overview_of_debugging_tools.html#remote-in-scene-dock
This is where Remote scene tree is located. Looking at the PR I linked, the code might be in different file than the local scene tree, but drag and drop functionality should be the same. Just look for get_drag_data and related methods in scene_tree_editor.cpp and try to implement it for the other tree.

@Calinou Calinou changed the title Node path drag and drop in remote scenetree Implement NodePath drag and drop in remote scene tree Mar 25, 2021
@akien-mga akien-mga added this to the 4.0 milestone Jul 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants