Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

return no access on non nummeric programIds #6384

Merged
merged 2 commits into from
Jan 15, 2025

Conversation

RubenGeo
Copy link
Contributor

@RubenGeo RubenGeo commented Jan 14, 2025

AB#32655

Describe your changes

Checklist before requesting a review

  • I have performed a self-review of my code
  • I have added tests wherever relevant
  • I have made sure that all automated checks pass before requesting a review
  • I do not need any deviation from our PR guidelines

Portalicious preview deployment

This PR does not have any preview deployments yet.

@Copilot Copilot bot review requested due to automatic review settings January 14, 2025 13:25
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.

Comments suppressed due to low confidence (1)

services/121-service/src/user/user.service.ts:87

  • [nitpick] The comment could be clearer. Suggested change: 'The query builder cannot handle non-numeric programIds, so we need to check it here.'
// the query builder cannot handle this so we need to check it here

services/121-service/src/user/user.service.ts Outdated Show resolved Hide resolved
@RubenGeo RubenGeo enabled auto-merge (squash) January 14, 2025 13:26
@RubenGeo RubenGeo added the bugfix Something that affects our end users is fixed label Jan 14, 2025
Ruben and others added 2 commits January 15, 2025 11:54
Signed-off-by: Ruben <vandervalk@geoit.nl>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@RubenGeo RubenGeo force-pushed the fix.500-error-undefinend-programId branch from 789370f to b81d6d9 Compare January 15, 2025 10:54
@RubenGeo RubenGeo merged commit d174b08 into main Jan 15, 2025
6 checks passed
@RubenGeo RubenGeo deleted the fix.500-error-undefinend-programId branch January 15, 2025 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Something that affects our end users is fixed
Development

Successfully merging this pull request may close these issues.

2 participants