Context access might be invalid: ACT

[Zageron]

Describe the bug
I believe this is a quality of life issue rather than a bug.
It would be nice for there to be a documented way, perhaps a quick actions, to ignore certain warnings.

The issue is that if: ${{ !env.ACT }} warns that ACT might be invalid. Which it will be when not running in an environment that defines ACT. Not sure if warning that an environment variable might not be declared is useful.

To Reproduce
Steps to reproduce the behavior:

1. Create any workflow block that contains an if statement referencing an environment variable that isn't declared in an env block.

Expected behavior
Either no warning, or a way to set particular environment variables to be ignored in this context.

Screenshots

Extension Version
v0.25.3

[Zageron]

After further searching, appears to be a duplicate of both #61 and #47.

[janaka]

I'm also experiencing this issue. It makes no sense to me that this warning is being issued. Either the extension can validate all context or if it cannot do some then don't do any. Given that variables and secrets are viewable on the left I would imagine if can validate.

[leonardorb]

Also having this issue. Is there a way to validate the context here?

[tylerclark]

Fixed in next release: #61 (comment)

[felipesu19]

Closing for fix in next release 💯

[floehopper]

@tylerclark:

Fixed in next release: #61 (comment)

I can't see a commit which fixes this - even an unreleased one. Where did you see it was fixed?

[wtachau]

Still seeing this issue FYI

[elviskahoro]

I'm also still seeing this!

[80rian]

definitely not fixed in the latest version.

[avh03]

same here, the issue still persists in 0.25.8

[marcospgp]

I would love to have no yellow underline on my workflow files :)

[brunokloss]

i'm almost disabling the extension... problem showing in v.0.25.8 here too :(

[matlads]

I am disabling the extension for now. i'll check back in about 5 months 😞

[Zageron]

@felipesu19 @cschleiden
Ya'll are posting in a closed issue, no one is going to see this. Pinging for visibility.

[cschleiden]

Have you tried declaring ACT as an environment variable? Something like

name: Demo workflow

env:
  ACT:

on:
  push:
  workflow_dispatch:
    inputs:
      name:
        type: string

jobs:
  say-hello:
    runs-on: ubuntu-latest

    steps:
      - run: echo "Hello ${{ env.ACT }}"

[PrimeTimeTran]

I uninstalled, reinstalled and restarted VSCode and then the warnings went away.

[epreston]

Have you tried declaring ACT as an environment variable? Something like

That didn't seem to work as expected. The "secrets" object is a simple dictionary of name / value pairs. Is it possible to add a config section for what we expect the object to look like ? Same with the env ? This way we don't need to erase the current value when its running to use an env or secret without warnings.

[cschleiden]

@epreston the secrets context is populated using the repository and org information from github.com. Does that not work for you? Or are you using GHES?

[epreston]

No. The issue is being able to add custom values.

It's good that it already has the values from the documentation.

[epreston]

So unless we only use the prepopulated attributes on secrets or env, our scripts are filled with error warnings. The purpose of these objects is to extend them.

A way to add known values to the shape of these objects, like adding words to a spell checker, would resolve this issue.

[cschleiden]

It uses the actual secrets configured for the repository, not just from the documentation.

[epreston]

Possible issue with that feature. What's the best way for me to help ? How can I generate a reproduction ?

[epreston]

One reproduction would be following the steps from https://app.codecov.io/

They have you create a:

secrets.CODECOV_TOKEN

Then when you go to edit that .yml file, it will always show this error where CODECOV_TOKEN is used.

Other plugins, like the spell checker, allow us to add words to the workspace settings to resolve similar issues.

[epreston]

I can confirm this works and is populated in github and that the plugin has no knowledge of the secrets configured for the repository.

[Zageron]

It would be a very impressive feature to have GH aware context. Just the keys mind you, values would not be good.

[cschleiden]

@Zageron that is supported by the extension:

[epreston]

@cschleiden what is required to allow the plugin to enumerate those secrets ?

[cschleiden]

Nothing, just login and open the checked out repository in vscode.

Edit: you need permissions to the repo, of course.

[epreston]

Since those Azure ones are well known and might be populated by the plugin staticly, could you create a secret named CODECOV_TOKEN and see if it appears in the list and allows it without warning ?

Thank you kindly.

[petrgazarov]

@epreston I had to uninstall/reinstall the extension for the secret names autocomplete to start working. Also, fixed the yellow underlines.

[AmrAhmedA]

Any possible fix?

[jacobmassengill]

@epreston I had to uninstall/reinstall the extension for the secret names autocomplete to start working. Also, fixed the yellow underlines.

This resolved the issue for me, can't believe I didn't try this first myself 😑

[ahmadnassri]

uninstall/reinstall only works temporarily, the issue still occurs if you're referencing organization secrets

[ahmadnassri]

I think this issue need to be re-opened

[MarioLiebisch]

Just installed the extension (0.26.2) and immediately stumbled over this, which is not helpful.

[mark-pictor-csec]

If I restart vscode, these warnings go away until I open a file under .github. But the instant I open one, all the warnings come back.

In my case the underlying cause seems to be a lack of alias support (#239).