tool-call: support Command R7B (+ return tool_plan "thoughts" in API)
#11585
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
41 tasks
ggerganov
approved these changes
Feb 2, 2025
examples/server/server.cpp
Outdated
Comment on lines
383
to
386
| if (ids.size() == 1) { | ||
| LOG_DBG("Preserved token: %d\n", ids[0]); | ||
| params.sampling.preserved_tokens.insert(ids[0]); | ||
| } |
There was a problem hiding this comment.
Here we don't handle ids.size() > 1
There was a problem hiding this comment.
Ah good point, just added a comment + debug warning log for now, should only happen when using a native tool call format with an incompatible model (e.g. wrong template override)
This was referenced Feb 3, 2025
tinglou
pushed a commit
to tinglou/llama.cpp
that referenced
this pull request
Feb 13, 2025
…I) (ggml-org#11585) * `tool-call`: support Command R7B (w/ tool_plan return) * `tool-call`: cleaner preservation of tokens + warn when likely bad chat template override * `tool-call`: test cleanup / handle lazy grammar triggers
orca-zhang
pushed a commit
to orca-zhang/llama.cpp
that referenced
this pull request
Feb 26, 2025
…I) (ggml-org#11585) * `tool-call`: support Command R7B (w/ tool_plan return) * `tool-call`: cleaner preservation of tokens + warn when likely bad chat template override * `tool-call`: test cleanup / handle lazy grammar triggers
arthw
pushed a commit
to arthw/llama.cpp
that referenced
this pull request
Feb 26, 2025
…I) (ggml-org#11585) * `tool-call`: support Command R7B (w/ tool_plan return) * `tool-call`: cleaner preservation of tokens + warn when likely bad chat template override * `tool-call`: test cleanup / handle lazy grammar triggers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CohereForAI/c4ai-command-r-v01norCohereForAI/c4ai-command-r-plustrigger detection (different format)Note
Needs a template override:
cf. #9639