-
Notifications
You must be signed in to change notification settings - Fork 295
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixed check_space_for_hashtable to use args.n_tables #382
Conversation
|
Fixes #380. |
Ready for review, if tests pass. |
Test FAILed. |
test this please. |
Test PASSed. |
ready for review. |
@@ -53,7 +53,7 @@ def main(): | |||
check_file_status(_) | |||
|
|||
check_space(args.input_filenames) | |||
check_space_for_hashtable(args.ksize * args.min_tablesize) | |||
check_space_for_hashtable(float(args.n_tables * args.min_tablesize) / 8.) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we define these arguments to be type float to avoid the need for this (and future potential bugs)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On Sun, Apr 13, 2014 at 11:58:32AM -0700, Michael R. Crusoe wrote:
@@ -53,7 +53,7 @@ def main():
check_file_status(_)check_space(args.input_filenames)
- check_space_for_hashtable(args.ksize * args.min_tablesize)
- check_space_for_hashtable(float(args.n_tables * args.min_tablesize) / 8.)
Should we define these arguments to be type float to avoid the need for this (and future potential bugs)?
I don't think it's necessary, I guess. I could go either way. Any points
of evidence that this is needed? I can't think of anywhere else this is
done.
--t
C. Titus Brown, ctb@msu.edu
I've added an issue re improving the test coverage. |
…wrong fixed check_space_for_hashtable to use args.n_tables
Fixes bug where table size was calculated based on args.ksize instead of args.n_tables. Important bug to fix for some cloud computing systems w/limited disk space.