Let's make this great project even better

[viking1304]

I like this project very much, but I do not like the outdated information in the documentation. I also do not like missing support for new node versions.

I am more than willing to help with both.

I created a pull request foundation/foundation-emails-template#70 that fixes an error when running the project with node v10.

I also created a pull request foundation/foundation-emails-template#71 that adds support for node 16 and newer.

While we are waiting for the merge, you can use v12 or v14 with the official repository

❯ git clone /~https://github.com/viking1304/foundation-emails-template test

or you can temporarily use my version that works with all node versions from v10 to v19

❯ git clone /~https://github.com/viking1304/foundation-emails-template test

If you are using the official repo, be sure to switch to node v12 or v14 before installing modules.

❯ cd test
❯ nvm use v14
❯ npm install

If you use my repo, you can use any node you want (v10-v19)

❯ cd test
❯ npm install

To compile use:

❯ npm start

To compile everything and inline CSS:

❯ npm run build

I am also willing to help with documentation and potentially new examples.

I hope we can finally close off those issues after the merge:

#1113 #1120 #1124 #1127 #1129 #1139

[joeworkman]

Thank you. I will look at these and get this merged in. Much appreciated.

[viking1304]

May you please tell me if node v10 should be supported?

I want to make more PRs and update used libraries, but in some cases, we can't use the latest versions of those libraries if we need to maintain v10 compatibility.

If we want to maintain v10 compatibility, the foundation for emails framework itself should be patched too.

If you decide to ditch v10, I will close PR foundation/foundation-emails-template#70

[elcaptain]

thanks so much for your work @viking1304 👏
would be great to get your fixes merged!

[viking1304]

thanks so much for your work @viking1304 👏 would be great to get your fixes merged!

I really hope @joeworkman will find some time to check and merge my fixes. There are some new PRs that can potentially clash with mine since they used the original version as a base to apply their fixes.

[simon-guider]

This works the first time. You saved me so much time.

I hope your PR's get merged soon

@joeworkman any news on this?