-
-
Notifications
You must be signed in to change notification settings - Fork 233
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The new Angular support not working properly #72
Comments
I'm not an angular dev myself, but maybe @Waterstraal who contributed the angular content can weigh in. One thing to keep in mind is AutoAnimate is ESM only — meaning if your build environment requires Common JS modules you might have issues. |
I think the default Angular app uses ESM, so that shouldn't be a problem, but from what I know compiling Angular libraries is not that straightforward (I am pretty sure you have to have all angular dependencies, with their compiler too) |
Ah yes, @PointSingularity you're right. We would probably need to set up ng-packagr to create a valid Angular Package Format package. This is something that's usually abstracted away when using the Angular CLI, but in this repository that's of course not the case... Sadly, I don't have much time to investigate this. Can you pick this up @PointSingularity? |
@Waterstraal Sadly I don't have any free time I can devote to this :( It really is unfortunate that the if you want to build a proper angular library, you need additional tooling. The easiest solution IMO would be to just show how to create your own directive, and how to import it, which from what I've seen @Waterstraal has already done. |
Any updates on this? |
Hey folks, just chiming in. I got this to work in my own project implementing it as a directive similar to what @Waterstraal did. 2 ways this can go without major change this repository setup.
|
@natealcedo Is there a guide on how to create your own direct? if yes can you please provide the link. That would be awesome! |
@Amrhub I just copied the implementation in this repository |
Hi, I have independently published a library for this since setting up
v0.0.1 is essentially the same code as committed in this repo, except that I do not use Example:
There are currently no docs, but I will try to update this. Also, I plan to support global default values, such as a custom animation duration which can be configured at the module level. I will look into how that would work with standalone directives. Edit: I just pushed v0.0.2 to support global options via an
In the README, I have expressed my interest in merging my code into this library if feasible, but it is a non-trivial ask. Edit 2: v0.4.1 now supports SSR, using |
Great... I understand this is only for Angular 16? |
It should work with any version of Angular, but the You can also copy the source code from this repo itself and maintain it to use in your projects. The only issue in this repo is the lack of a build step. |
I just saw the new release, and I wanted to try out the new Angular support. I created a new Angular v14 application, tried the steps in the documentation, and I am getting this error:
The text was updated successfully, but these errors were encountered: