Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix "Close after capture" mode #569

Closed
wants to merge 1 commit into from

Conversation

bodwok
Copy link

@bodwok bodwok commented Jun 27, 2019

Fixed closing the application if "close after capture" mode is set

Steps:

  1. Check the box "close after capture"
  2. Press on the button "Choose an app to open the capture" or "Upload to Imgur" or "Pin image on the desktop"

Observed Behavior:
The application is closed

Expected Behavior:
The widget will open
When the widget will close the application will be closed

@arjunv
Copy link

arjunv commented May 14, 2020

Update: Issue does not pertain this PR but with master

@ElijahLynn
Copy link

After enabling Close after capture option, the only working functionality is saving the screenshot to a file - either through normal Save Image function or using Copy image to clipboard function with Save image after copy option enabled. The results were the same when using Keyboard shortcuts or the GUI buttons.

Functionality Matrix when Close after Capture option is enabled

Action Image Saved Image Copied to Clipboard Image Uploaded Image URL Copied to Clipboard
Save Image ✓
Copy Image to Clipboard ✗
Copy Image to Clipboard + Save Image ✓ ✗
Upload Image ✗
Upload Image + Copy URL to Clipboard ✗ ✗

Is that with this PR or on master?

@borgmanJeremy
Copy link
Contributor

Can you look into why this doesn't fix copying the URL before we merge it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants