Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CWv1: SyncIncomingBlocks data leaks into sync processes #70

Closed
placer14 opened this issue Sep 2, 2020 · 2 comments · Fixed by filecoin-project/lotus#3526
Closed

CWv1: SyncIncomingBlocks data leaks into sync processes #70

placer14 opened this issue Sep 2, 2020 · 2 comments · Fixed by filecoin-project/lotus#3526
Assignees
@placer14
Labels
kind/bug Something isn't working

Comments

@placer14
Copy link
Contributor

placer14 commented Sep 2, 2020

Blocks coming from SyncIncomingBlocks are not necessarily accessible to the node after being received. These blocks were getting into the sync pipeline and causing a bunch of unaccessble state errors (since those messages are not necessarily applied to the chain).
@placer14 placer14 added the kind/bug Something isn't working label Sep 2, 2020
@placer14 placer14 self-assigned this Sep 2, 2020
@placer14
Copy link
Contributor Author

placer14 commented Sep 2, 2020

A fix for this has been prepared and deployed for Staging for testing. Preparing a PR today.

@placer14
Copy link
Contributor Author

placer14 commented Sep 3, 2020

Also found that this caused panics in the processor. Instead of killing the entire chainwatch process with a panic, we're going to error into the logs.

@placer14 placer14 mentioned this issue Sep 3, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@placer14 placer14

Labels
kind/bug Something isn't working
Projects
None yet
Milestone
No milestone
1 participant
@placer14