Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unexpected derived_gas_output.base_fee_burn values since FIP-0009 #354

Closed
olizilla opened this issue Jan 14, 2021 · 1 comment · Fixed by #356
Closed

Unexpected derived_gas_output.base_fee_burn values since FIP-0009 #354

olizilla opened this issue Jan 14, 2021 · 1 comment · Fixed by #356
Assignees
Labels
backfill required Alters data extraction such that backfilling is necessary kind/bug Kind: Bug

Comments

@olizilla
Copy link
Contributor

olizilla commented Jan 14, 2021

Since FIP-0009 the value for BaseBurnFee should be 0 for SubmitWindowedPoSt messges as per /~https://github.com/filecoin-project/FIPs/blob/master/FIPS/fip-0009.md#test-cases

The visor derived_gas_ouput table does not show any zero values in the base_burn_fee column for SubmitWindowedPoSt

SELECT o.cid, o.actor_name, o.method, o.base_fee_burn, o.over_estimation_burn
    FROM derived_gas_outputs o
    WHERE height >= 300000
      AND height < 400000
      AND actor_name = 'fil/2/storageminer'
      AND method = 5
      AND base_fee_burn = '0'

- returns no results

We rely on the lotus/chain/vm ComputeGasOutputs function to populate the values... and that module changed with the 1.4 release of lotus that included FIP-0009 so we need to upgrade our lotus dep and reingest.

/~https://github.com/filecoin-project/sentinel-visor/blob/4ae639cbea3f5826ee42ef32fdc587ed39e60d06/chain/message.go#L166-L191

Visor Version: v0.4

@olizilla olizilla added the kind/bug Kind: Bug label Jan 14, 2021
@iand
Copy link
Contributor

iand commented Jan 14, 2021

Requires some updates to dependencies. filecoin-project/lotus#5355 and willscott/carbs#9

@iand iand added the backfill required Alters data extraction such that backfilling is necessary label Jan 14, 2021
@iand iand self-assigned this Jan 14, 2021
@iand iand closed this as completed in #356 Jan 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backfill required Alters data extraction such that backfilling is necessary kind/bug Kind: Bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants