Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

getDevDescr () fails on some devices. #563

Closed
YuuichiAkagawa opened this issue Nov 14, 2020 · 4 comments
Closed

getDevDescr () fails on some devices. #563

YuuichiAkagawa opened this issue Nov 14, 2020 · 4 comments

Comments

@YuuichiAkagawa
Copy link
Contributor

I am trying to support the Novation Circuit. However, faild on getDevDescr().
This device returns only 8 bytes of Device Descriptor by default address.
circuit-failed-on-UHS2

So I tried the Windows style method and it worked.
https://techcommunity.microsoft.com/t5/microsoft-usb-blog/how-does-usb-stack-enumerate-a-device/ba-p/270685

Usb.cpp
/~https://github.com/felis/USB_Host_Shield_2.0/blob/master/Usb.cpp#L718-L719

        // Get device descriptor
//        rcode = getDevDescr(0, 0, sizeof (USB_DEVICE_DESCRIPTOR), (uint8_t*)buf);
        rcode = getDevDescr(0, 0, 8, (uint8_t*)buf);

usbh_midi.cpp
YuuichiAkagawa/USBH_MIDI@a718bf6

Then
circuit-fixed-on-UHS2

@Lauszus
Copy link
Collaborator

Lauszus commented Nov 15, 2020

Very interesting. Have you seen any other devices that has this behavior?

@YuuichiAkagawa
Copy link
Contributor Author

I don't know other devices. I encountered it for the first time.

@Lauszus
Copy link
Collaborator

Lauszus commented Nov 16, 2020

Okay. For now we can just add it to your MIDI drivers. Feel free to send a PR once the code is ready.

@YuuichiAkagawa YuuichiAkagawa changed the title GetDevDescr () fails on some devices. getDevDescr () fails on some devices. Nov 23, 2020
@Lauszus
Copy link
Collaborator

Lauszus commented Nov 23, 2020

Closing, as #566 has been merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants