Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: resourceId not set as literal #37

Closed
Morriz opened this issue Feb 27, 2017 · 2 comments
Closed

bug: resourceId not set as literal #37

Morriz opened this issue Feb 27, 2017 · 2 comments

Comments

@Morriz
Copy link

Morriz commented Feb 27, 2017

when a post/put/patch is done, the resourceId is not expanded, as the url contains dynamic ids, like {_id}, instead of always {resourceId}

I have fixed this by replacing line lib/index.js:105 with:

    var withIdKey = '/' + path + '/{resourceId}';

Sorry, but I don't have the time right now to do a proper pull request.

@daffl
Copy link
Member

daffl commented Mar 14, 2017

You can make that change in the browser by editing the file at /~https://github.com/feathersjs/feathers-swagger/edit/master/src/index.js. GitHub then gives you the option to automatically create a pull request from it.
A pull request will help get this fix released significantly faster.

@Mairu
Copy link
Collaborator

Mairu commented May 24, 2019

Was fixed with #68

@Mairu Mairu closed this as completed May 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants