Paginate option for a feathers-sequelize service is not working as expected

[katerina-semikina]

Steps to reproduce

If paginate option is set to false for a service, count query is still created while calling find service method.

Example:

const Model = require('./models/mymodel');
const service = require('feathers-sequelize');

const paginate = false;
app.use('/messages', service({ Model, paginate }));

Expected behavior

Model.findAll is invoked instead if Model.findAndCountAll.

Actual behavior

Model.findAndCountAll is invoked. Extra count query is executed.

The reason is the following case:

• Service initialization:

If options.paginate is false, then this.paginate becomes equal to {}.

this.paginate = options.paginate || {};

link to the line

• find method:

If params.paginate is undefined, then this.paginate value is assigned to paginate variable, so paginate becomes equal to {}.

const paginate = (params && typeof params.paginate !== 'undefined') ? params.paginate : this.paginate;

link to the line

• _find method:

If paginate is {}, then the condition is true, so Model.findAndCountAll is called.

    if (paginate) {
      return Model.findAndCountAll(q).then(result => {
        // ...
      }).catch(utils.errorHandler);
    } else {
      return Model.findAll(q).then(result => {
        // ...
      }).catch(utils.errorHandler);
    }

link to the line

System configuration

Feathers-sequelize version: 2.3.0

NodeJS version: 8.1.2

Operating System: macOS 10.12.6

[ninique]

Just ran into this issue myself. If I turn off pagination in a hook by setting params.paginate = false there it works. But if I turn it off when initializing the service it does not.

[amaanm]

I can confirm that I am also experiencing this, and I successfully used the same fix as @katerina-semikina

@ninique the hook fix also works, since the hook param for paginate being false is correctly checked in the find method.

[alex-friedl]

I ran into this myself.

The issue is line 18 in index.js
this.paginate = options.paginate || {};

Removing the default `|| {}' should fix the issue.

[daffl]

That should do it. Pull request welcome.

[alex-friedl]

Opened #217