-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The patch on postgres is selecting every row from the table before updating #168
Comments
I think you're right. Can you describe the behaviour you are seeing? If it is what I think I'd be surprised that the tests (or somebody else) didn't catch it before. |
With the debug level logs I can see it make two queries against the table one for the count the other for every row. The queries have no where clauses while the update does. I believe the first two queries are coming from the this._getOrFind function call. |
I think that makes sense. Could you submit a PR with the change you proposed? |
Closed via #169 |
I believe the line
should be
/~https://github.com/feathersjs/feathers-sequelize/blob/edc431f82018b7f6f376030d05225b017f26bc41/src/index.js#L180
The text was updated successfully, but these errors were encountered: