Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

autoCorrect not working on android api 27 #18457

Closed
3 tasks done
jimji1005 opened this issue Mar 20, 2018 · 13 comments
Closed
3 tasks done

autoCorrect not working on android api 27 #18457

jimji1005 opened this issue Mar 20, 2018 · 13 comments
Labels
Component: TextInput Related to the TextInput component. Issue: Author Provided Repro This issue can be reproduced in Snack or an attached project. Platform: Android Android applications. Stale There has been a lack of activity on this issue and it may be closed soon.

Comments

@jimji1005
Copy link

On android api 27, autoCorrect={false} of TextInput does not disable auto suggest.

Environment

Environment:
OS: macOS High Sierra 10.13.3
Node: 8.6.0
Yarn: 1.3.2
npm: 5.6.0
Watchman: 4.9.0
Xcode: Xcode 9.2 Build version 9C40b
Android Studio: 3.0 AI-171.4443003

Packages: (wanted => installed)
react: ^16.3.0-alpha.1 => 16.3.0-alpha.2
react-native: 0.54.2 => 0.54.2

Steps to Reproduce

  1. clone repo, yarn, run-android
    /~https://github.com/jimji1005/rn-android-keyboard-bug
    or

  2. react-native init testProject

  3. add TextInput and autoCorrrect={false}

  4. launch on android emulator or device with api 27

  5. type into textinput

Expected Behavior

auto suggest would be disabled

Actual Behavior

auto suggest still working

rn0bug-android-keyboard

@react-native-bot react-native-bot added the Platform: Android Android applications. label Mar 20, 2018
@hramos hramos added Issue: Author Provided Repro This issue can be reproduced in Snack or an attached project. Component: TextInput Related to the TextInput component. labels Mar 20, 2018
@jimji1005
Copy link
Author

Works correctly on API26

rn0bug-android-keyboard0

@react-native-bot react-native-bot added the Platform: macOS Building on macOS. label Mar 20, 2018
@hramos hramos removed the Platform: macOS Building on macOS. label Mar 29, 2018
@devAstro81
Copy link

@jimji1005 till the bug is fixed, you can use 'email-address' keyboard type.

@SwiftPolar
Copy link

SwiftPolar commented Apr 19, 2018

@tomdev-biz I'm using visible-password instead and it works as a workaround too.

Can confirm on this particular bug.

@pennyandsean
Copy link

Unfortunately visible-password doesn't work for my application as I need autoCapitalize="characters" as well which isn't available with visible-password

@devAstro81
Copy link

@pennyandsean if you update your react-native version, visible-password will work.
On some android devices, email-address not working as expected, so I also suggest to use visible-password with updating your react-native version.

@malonguwa
Copy link

@tomdev-biz could you provide more info about "On some android devices, email-address not working as expected", what's the issue? and when I use visible-password type in RN 0.55.3, I do not see cursor indicator or the text in the textInput when it focus, but other type such as default or email-address is working... no idea what happens...... how did you use visible-password in your TextInput component?

@binki
Copy link

binki commented Jul 6, 2018

Even though you say that Android isn’t respecting autoCorrect={false}, it actually is. It will not automatically highlight the most likely candidate and replace it when you type ., , etc.. However, if you put autoCorrect={true}, it will automatically choose and correct with the most likely candidate. I.e., autocorrect is disabled but autosuggestions aren’t.

Have you actually tried typing? In your video, I only see you clicking directly on the autosuggestions but not actually demonstrating autoCorrect in action.

Sorry I am unable to actually try building with Android Studio at the moment. My observations are from using Expo on my Android-8.1 phone. I made a video demonstrating that autoCorrect={false} works as I described.

@tarouboy
Copy link

tarouboy commented Jul 20, 2018

Unfortunately, both email-address and visible-password doesn't fit the multi-line usage. It will cause the textInput to ignore the multiline props and/or the return key not going to the next line.

I wish to apply the commit #18443 however I don't understand the flow to build from source :(
Any other workarounds? please help :(

@florindumitru
Copy link

I have the same problem :(

@jeremy-farnault
Copy link

Working for us with visible-password but we had to remove our autoCapitalize and our multiline configuration.

@ericjames
Copy link

Confirm visible-password disables autocorrect on Android 6.0

@stale
Copy link

stale bot commented Dec 21, 2018

Hey there, it looks like there has been no activity on this issue recently. Has the issue been fixed, or does it still require the community's attention? This issue may be closed if no further activity occurs. You may also label this issue as "For Discussion" or "Good first issue" and I will leave it open. Thank you for your contributions.

@stale stale bot added the Stale There has been a lack of activity on this issue and it may be closed soon. label Dec 21, 2018
@stale
Copy link

stale bot commented Dec 28, 2018

Closing this issue after a prolonged period of inactivity. If this issue is still present in the latest release, please feel free to create a new issue with up-to-date information.

@stale stale bot closed this as completed Dec 28, 2018
@facebook facebook locked as resolved and limited conversation to collaborators Dec 29, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Component: TextInput Related to the TextInput component. Issue: Author Provided Repro This issue can be reproduced in Snack or an attached project. Platform: Android Android applications. Stale There has been a lack of activity on this issue and it may be closed soon.
Projects
None yet
Development

No branches or pull requests