Skip to content

Commit

Permalink
Remove unused loads from build files.
Browse files Browse the repository at this point in the history 
Summary: Unused loads hurt readability and take time to process.

Reviewed By: hramos

Differential Revision: D9494120

fbshipit-source-id: 455b56efadab1cb976344cffcb427772bfda2f71
  • Loading branch information
@ttsugriy @facebook-github-bot
ttsugriy authored and facebook-github-bot committed Sep 1, 2018
1 parent 09c78fe commit a8a63b1
Show file tree
Hide file tree
Showing 16 changed files with 25 additions and 29 deletions.
2 changes: 1 addition & 1 deletion ReactAndroid/src/main/java/com/facebook/react/uimanager/common/BUCK
View file
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
load("//tools/build_defs/oss:rn_defs.bzl", "react_native_dep", "react_native_target", "rn_android_library")
load("//tools/build_defs/oss:rn_defs.bzl", "react_native_dep", "rn_android_library")

rn_android_library(
name = "common",
Expand Down
2 changes: 1 addition & 1 deletion ReactAndroid/src/test/java/com/facebook/react/fabric/BUCK
View file
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
load("//tools/build_defs/oss:rn_defs.bzl", "IS_OSS_BUILD", "YOGA_TARGET", "react_native_dep", "react_native_target", "react_native_tests_target", "rn_robolectric_test")
load("//tools/build_defs/oss:rn_defs.bzl", "IS_OSS_BUILD", "react_native_dep", "react_native_target", "react_native_tests_target", "rn_robolectric_test")

rn_robolectric_test(
name = "fabric",
Expand Down
8 changes: 4 additions & 4 deletions ReactCommon/fabric/attributedstring/BUCK
View file
Original file line number Diff line number Diff line change
@@ -1,14 +1,14 @@
load("@xplat//configurations/buck/apple:flag_defs.bzl", "OBJC_ARC_PREPROCESSOR_FLAGS", "get_application_ios_flags", "get_debug_preprocessor_flags")
load("@xplat//configurations/buck/apple:flag_defs.bzl", "get_debug_preprocessor_flags")
load(
"//tools/build_defs/oss:rn_defs.bzl",
"ANDROID",
"APPLE",
"fb_xplat_cxx_test",
"get_apple_compiler_flags",
"get_apple_inspector_flags",
"react_native_xplat_target",
"get_apple_compiler_flags",
"subdir_glob",
"fb_xplat_cxx_test",
"rn_xplat_cxx_library",
"subdir_glob",
)

APPLE_COMPILER_FLAGS = get_apple_compiler_flags()
Expand Down
4 changes: 2 additions & 2 deletions ReactCommon/fabric/components/activityindicator/BUCK
View file
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
load("@xplat//configurations/buck/apple:flag_defs.bzl", "OBJC_ARC_PREPROCESSOR_FLAGS", "get_application_ios_flags", "get_debug_preprocessor_flags")
load("//tools/build_defs/oss:rn_defs.bzl", "ANDROID", "APPLE", "subdir_glob", "fb_xplat_cxx_test", "get_apple_compiler_flags", "get_apple_inspector_flags", "react_native_xplat_target", "rn_xplat_cxx_library")
load("@xplat//configurations/buck/apple:flag_defs.bzl", "get_debug_preprocessor_flags")
load("//tools/build_defs/oss:rn_defs.bzl", "ANDROID", "APPLE", "fb_xplat_cxx_test", "get_apple_compiler_flags", "get_apple_inspector_flags", "react_native_xplat_target", "rn_xplat_cxx_library", "subdir_glob")

APPLE_COMPILER_FLAGS = get_apple_compiler_flags()

Expand Down
2 changes: 1 addition & 1 deletion ReactCommon/fabric/components/image/BUCK
View file
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
load("@xplat//configurations/buck/apple:flag_defs.bzl", "OBJC_ARC_PREPROCESSOR_FLAGS", "get_application_ios_flags", "get_debug_preprocessor_flags")
load("@xplat//configurations/buck/apple:flag_defs.bzl", "get_debug_preprocessor_flags")
load(
"//tools/build_defs/oss:rn_defs.bzl",
"ANDROID",
Expand Down
4 changes: 2 additions & 2 deletions ReactCommon/fabric/components/root/BUCK
View file
Original file line number Diff line number Diff line change
@@ -1,14 +1,14 @@
load("@xplat//configurations/buck/apple:flag_defs.bzl", "OBJC_ARC_PREPROCESSOR_FLAGS", "get_application_ios_flags", "get_debug_preprocessor_flags")
load("@xplat//configurations/buck/apple:flag_defs.bzl", "get_debug_preprocessor_flags")
load(
"//tools/build_defs/oss:rn_defs.bzl",
"ANDROID",
"APPLE",
"subdir_glob",
"fb_xplat_cxx_test",
"get_apple_compiler_flags",
"get_apple_inspector_flags",
"react_native_xplat_target",
"rn_xplat_cxx_library",
"subdir_glob",
)

APPLE_COMPILER_FLAGS = get_apple_compiler_flags()
Expand Down
2 changes: 1 addition & 1 deletion ReactCommon/fabric/components/scrollview/BUCK
View file
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
load("@xplat//configurations/buck/apple:flag_defs.bzl", "OBJC_ARC_PREPROCESSOR_FLAGS", "get_application_ios_flags", "get_debug_preprocessor_flags")
load("@xplat//configurations/buck/apple:flag_defs.bzl", "get_debug_preprocessor_flags")
load(
"//tools/build_defs/oss:rn_defs.bzl",
"ANDROID",
Expand Down
6 changes: 3 additions & 3 deletions ReactCommon/fabric/components/switch/BUCK
View file
Original file line number Diff line number Diff line change
@@ -1,14 +1,14 @@
load("@xplat//configurations/buck/apple:flag_defs.bzl", "OBJC_ARC_PREPROCESSOR_FLAGS", "get_application_ios_flags", "get_debug_preprocessor_flags")
load("@xplat//configurations/buck/apple:flag_defs.bzl", "get_debug_preprocessor_flags")
load(
"//tools/build_defs/oss:rn_defs.bzl",
"ANDROID",
"APPLE",
"fb_xplat_cxx_test",
"get_apple_compiler_flags",
"subdir_glob",
"get_apple_inspector_flags",
"react_native_xplat_target",
"fb_xplat_cxx_test",
"rn_xplat_cxx_library",
"subdir_glob",
)

APPLE_COMPILER_FLAGS = get_apple_compiler_flags()
Expand Down
2 changes: 1 addition & 1 deletion ReactCommon/fabric/components/text/BUCK
View file
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
load("@xplat//configurations/buck/apple:flag_defs.bzl", "OBJC_ARC_PREPROCESSOR_FLAGS", "get_application_ios_flags", "get_debug_preprocessor_flags")
load("@xplat//configurations/buck/apple:flag_defs.bzl", "get_debug_preprocessor_flags")
load(
"//tools/build_defs/oss:rn_defs.bzl",
"ANDROID",
Expand Down
2 changes: 1 addition & 1 deletion ReactCommon/fabric/components/view/BUCK
View file
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
load("@xplat//configurations/buck/apple:flag_defs.bzl", "OBJC_ARC_PREPROCESSOR_FLAGS", "get_application_ios_flags", "get_debug_preprocessor_flags")
load("@xplat//configurations/buck/apple:flag_defs.bzl", "get_debug_preprocessor_flags")
load(
"//tools/build_defs/oss:rn_defs.bzl",
"ANDROID",
Expand Down
4 changes: 2 additions & 2 deletions ReactCommon/fabric/core/BUCK
View file
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
load("@xplat//configurations/buck/apple:flag_defs.bzl", "OBJC_ARC_PREPROCESSOR_FLAGS", "get_application_ios_flags", "get_debug_preprocessor_flags")
load("//tools/build_defs/oss:rn_defs.bzl", "ANDROID", "APPLE", "subdir_glob", "fb_xplat_cxx_test", "get_apple_compiler_flags", "get_apple_inspector_flags", "react_native_xplat_target", "rn_xplat_cxx_library")
load("@xplat//configurations/buck/apple:flag_defs.bzl", "get_debug_preprocessor_flags")
load("//tools/build_defs/oss:rn_defs.bzl", "ANDROID", "APPLE", "fb_xplat_cxx_test", "get_apple_compiler_flags", "get_apple_inspector_flags", "react_native_xplat_target", "rn_xplat_cxx_library", "subdir_glob")

APPLE_COMPILER_FLAGS = get_apple_compiler_flags()

Expand Down
3 changes: 0 additions & 3 deletions ReactCommon/fabric/debug/BUCK
View file
Original file line number Diff line number Diff line change
@@ -1,7 +1,5 @@
load(
"//configurations/buck/apple:flag_defs.bzl",
"OBJC_ARC_PREPROCESSOR_FLAGS",
"get_application_ios_flags",
"get_debug_preprocessor_flags",
)
load(
Expand All @@ -11,7 +9,6 @@ load(
"fb_xplat_cxx_test",
"get_apple_compiler_flags",
"get_apple_inspector_flags",
"react_native_xplat_target",
"rn_xplat_cxx_library",
"subdir_glob",
)
Expand Down
2 changes: 1 addition & 1 deletion ReactCommon/fabric/events/BUCK
View file
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
load("@xplat//configurations/buck/apple:flag_defs.bzl", "OBJC_ARC_PREPROCESSOR_FLAGS", "get_application_ios_flags", "get_debug_preprocessor_flags")
load("@xplat//configurations/buck/apple:flag_defs.bzl", "get_debug_preprocessor_flags")
load(
"//tools/build_defs/oss:rn_defs.bzl",
"ANDROID",
Expand Down
3 changes: 1 addition & 2 deletions ReactCommon/fabric/graphics/BUCK
View file
Original file line number Diff line number Diff line change
@@ -1,12 +1,11 @@
load("@xplat//configurations/buck/apple:flag_defs.bzl", "OBJC_ARC_PREPROCESSOR_FLAGS", "get_application_ios_flags", "get_debug_preprocessor_flags")
load("@xplat//configurations/buck/apple:flag_defs.bzl", "get_debug_preprocessor_flags")
load(
"//tools/build_defs/oss:rn_defs.bzl",
"ANDROID",
"APPLE",
"fb_xplat_cxx_test",
"get_apple_compiler_flags",
"get_apple_inspector_flags",
"react_native_xplat_target",
"rn_xplat_cxx_library",
"subdir_glob",
)
Expand Down
6 changes: 3 additions & 3 deletions ReactCommon/fabric/imagemanager/BUCK
View file
Original file line number Diff line number Diff line change
@@ -1,13 +1,13 @@
load("@xplat//configurations/buck/apple:flag_defs.bzl", "OBJC_ARC_PREPROCESSOR_FLAGS", "get_application_ios_flags", "get_debug_preprocessor_flags")
load("@xplat//configurations/buck/apple:flag_defs.bzl", "get_debug_preprocessor_flags")
load(
"//tools/build_defs/oss:rn_defs.bzl",
"ANDROID",
"APPLE",
"get_apple_inspector_flags",
"fb_xplat_cxx_test",
"get_apple_compiler_flags",
"get_apple_inspector_flags",
"react_native_xplat_target",
"rn_xplat_cxx_library",
"fb_xplat_cxx_test",
"subdir_glob",
)

Expand Down
2 changes: 1 addition & 1 deletion ReactCommon/fabric/textlayoutmanager/BUCK
View file
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
load("@xplat//configurations/buck/apple:flag_defs.bzl", "OBJC_ARC_PREPROCESSOR_FLAGS", "get_application_ios_flags", "get_debug_preprocessor_flags")
load("@xplat//configurations/buck/apple:flag_defs.bzl", "get_debug_preprocessor_flags")
load(
"//tools/build_defs/oss:rn_defs.bzl",
"ANDROID",
Expand Down

0 comments on commit a8a63b1

Please sign in to comment.