-
-
Notifications
You must be signed in to change notification settings - Fork 8.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(npm2yarn): use forked npm-to-yarn; fix a few conversion bugs #6005
Conversation
✅ [V2]Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site settings. |
⚡️ Lighthouse report for the deploy preview of this PR
|
Co-authored-by: Joshua Chen <sidachen2003@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for these useful contributions 💯
FYI I'll more likely merge it as part of my own fork (as we'll likely move it to a docusaurus-core org someday) and publish it under @docusaurus
npm org.
Will do that soon, for now I'm focusing on category indexes
do we have any updates? |
@armano2 Could you rebase first? We are in a pretty awkward situation right now because the @Docusaurus organization is there but neither @slorber nor I have member access to it. Maybe we need to wait a bit more. No idea what FB politics is going on, but accepting forked code into our repo is very complicated as well (unlike two years ago). |
I don't forget, but waiting for @zpao to give me member access. Will figure out if we should take temporary actions immediately (ie use a fork) until the org is set up properly |
Is this something that we could just rewrite internally rather than forking externally? If @armano2 has ideas for how the package can be rewritten entirely - it would save having to go through any hoops at all and could just be integrated into the plugin directly. |
I don't know what's all the business around it, but I think we basically can't do anything meaningful about it😅
@bradzacher If TS-ESLint is open to forking the npm2yarn remark plugin, I can help facilitate that. |
rebased |
Thanks @armano2 Sorry for stalling this PR longer than it should have😞 Not in my will |
suppressed by #8650 |
@@ -35,7 +35,7 @@ The command also installs all necessary dependencies you need to run Docusaurus. | |||
|
|||
Run the development server: | |||
|
|||
```bash | |||
```bash npm2yarn |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe we should mvoe this change to #8650
@@ -23,7 +23,7 @@ Generate a new Docusaurus site using the **classic template**. | |||
|
|||
The classic template will automatically be added to your project after you run the command: | |||
|
|||
```bash | |||
```bash npm2yarn |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe we should mvoe this change to #8650
Motivation
I decided to fork
npm-to-yarn
package and add support for missing commands,yarn create name
->npm init name
andyarn init name
->npm create name
npm run x -- --args
->yarn x --args
oryarn run x --args
npm ls abc bcd
->yarn list --pattern "abc|bcd"
npm test/start/stop
->yarn test/start/stop
see:
fixes #5861
Note
There is pr for original package at nebrelbug/npm-to-yarn#22
i did more small fixes at /~https://github.com/armano2/npm-to-yarn/commits/main, mainly armano2/npm-to-yarn@2b91983
Test plans
https://deploy-preview-6005--docusaurus-2.netlify.app/docs/next/i18n/tutorial
https://deploy-preview-6005--docusaurus-2.netlify.app/docs/i18n/crowdin
https://deploy-preview-6005--docusaurus-2.netlify.app/docs/i18n/git/#initialize-the-i18n-folder