-
-
Notifications
You must be signed in to change notification settings - Fork 26.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CSS get bundled which breaks with custom properties #7748
Comments
This issue has been automatically marked as stale because it has not had any recent activity. It will be closed in 5 days if no further activity occurs. |
I'm facing a similar issue too. Would be good to be able to override the nano defaults. In my case they are minifying the font-face declaration which then breaks fonts in IE11 |
@sidonaldson yes, that would probably be the best way to handle this issue |
This issue has been automatically marked as stale because it has not had any recent activity. It will be closed in 5 days if no further activity occurs. |
Is anyone of the CRA team looking at this? |
I've added a PR to cure my specific issue but not to allow any overrides to be passed through #8106 |
I've merged #8106, but i don't believe that will fix this issue. |
@ianschmitz indeed. The best possible fix would be the ability to override the CSS minification defaults via package.json. Does CRA import overrides via package.json for any other customisation? |
We generally don't. I'd prefer if we find a better default configuration that solves this issue instead of exposing postcss etc. |
I am closing this issue, since I have moved from CRA to other options, also the lack of activity is not helping. |
With
react-scripts build
some css longhand properties get merged to a shorthand.This is not always the desired result and is breaking with css custom properties.
It would be nice if we could disable some compression options on a react build via a config.
Example also with the calc minification from css nano
Or this behavior gets fixed.
Input:
Becomes this:
Expected:
Environment Info:
System:
OS: macOS 10.14.6
CPU: (4) x64 Intel(R) Core(TM) i5-3210M CPU @ 2.50GHz
Binaries:
Node: 10.16.0 - /usr/local/opt/node@10/bin/node
Yarn: 1.17.0 - /usr/local/bin/yarn
npm: 6.9.0 - /usr/local/opt/node@10/bin/npm
Browsers:
Chrome: 78.0.3904.34
Firefox: Not Found
Safari: 13.0.1
npmPackages:
react: ^16.9.0 => 16.9.0
react-dom: ^16.9.0 => 16.9.0
react-scripts: ^3.1.1 => 3.1.1
npmGlobalPackages:
create-react-app: 3.0.1
The text was updated successfully, but these errors were encountered: