tests: ensure all errors are handled

expressjs · Jun 20, 2016 · 1050e7b · 1050e7b
1 parent 74d5ab5
commit 1050e7b
Show file tree

Hide file tree

Showing 5 changed files with 11 additions and 6 deletions.
diff --git a/test/body-parser.js b/test/body-parser.js
@@ -34,13 +34,14 @@ describe('bodyParser()', function(){
     .expect(200, '{"user":"tobi"}', done)
   })
 
-  it('should handle duplicated middleware', function(done){
+  it('should handle duplicated middleware', function (done) {
     var _bodyParser = bodyParser()
-    var server = http.createServer(function(req, res){
-      _bodyParser(req, res, function(err){
-        _bodyParser(req, res, function(err){
-          res.statusCode = err ? (err.status || 500) : 200;
-          res.end(err ? err.message : JSON.stringify(req.body));
+    var server = http.createServer(function (req, res) {
+      _bodyParser(req, res, function (err0) {
+        _bodyParser(req, res, function (err1) {
+          var err = err0 || err1
+          res.statusCode = err ? (err.status || 500) : 200
+          res.end(err ? err.message : JSON.stringify(req.body))
         })
       })
     })

diff --git a/test/json.js b/test/json.js
@@ -84,6 +84,7 @@ describe('bodyParser.json()', function(){
     var jsonParser = bodyParser.json()
     var server = createServer(function (req, res, next) {
       jsonParser(req, res, function (err) {
+        if (err) return next(err)
         jsonParser(req, res, next)
       })
     })

diff --git a/test/raw.js b/test/raw.js
@@ -54,6 +54,7 @@ describe('bodyParser.raw()', function(){
     var rawParser = bodyParser.raw()
     var server = createServer(function (req, res, next) {
       rawParser(req, res, function (err) {
+        if (err) return next(err)
         rawParser(req, res, next)
       })
     })

diff --git a/test/text.js b/test/text.js
@@ -58,6 +58,7 @@ describe('bodyParser.text()', function(){
     var textParser = bodyParser.text()
     var server = createServer(function (req, res, next) {
       textParser(req, res, function (err) {
+        if (err) return next(err)
         textParser(req, res, next)
       })
     })

diff --git a/test/urlencoded.js b/test/urlencoded.js
@@ -57,6 +57,7 @@ describe('bodyParser.urlencoded()', function(){
     var urlencodedParser = bodyParser.urlencoded()
     var server = createServer(function (req, res, next) {
       urlencodedParser(req, res, function (err) {
+        if (err) return next(err)
         urlencodedParser(req, res, next)
       })
     })