Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove setup.py #29

Closed
4 tasks done
tkilias opened this issue May 10, 2023 · 0 comments · Fixed by #30
Closed
4 tasks done

Remove setup.py #29

tkilias opened this issue May 10, 2023 · 0 comments · Fixed by #30
Assignees
@MarleneKress79789
Labels
refactoring Code improvement without behavior change

Comments

@tkilias
Copy link
Collaborator

tkilias commented May 10, 2023 •
edited by MarleneKress79789
Loading

Background

  • with poetry 1.4.0 it doesn't create the setup.py anymore /~https://github.com/python-poetry/poetry/releases/tag/1.4.0
  • we currently use poetry build to generate the setup.py
  • however, the setup.py isn't needed with newer pip versions and if there are releases to pypi or as wheels
  • for that reason, we can remove setup.py and githook that generates it, from this repo

Acceptance Criteria

  • Update workflows to poetry 1.4.0
  • Remove setup.py Github Workflow
  • Remove setup.py githook
  • Remove setup.py file
@tkilias tkilias added the refactoring Code improvement without behavior change label May 10, 2023
@MarleneKress79789 MarleneKress79789 self-assigned this May 11, 2023
@MarleneKress79789 MarleneKress79789 mentioned this issue May 11, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MarleneKress79789 MarleneKress79789

Labels
refactoring Code improvement without behavior change
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

29: Removed setup.py exasol/script-languages-container-ci
2 participants
@tkilias @MarleneKress79789