fix(no-unsupported): fix node:test module
#378
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichaelDeBoey
force-pushed
the
extract-test-globals-correctly
branch
2 times, most recently
from
8b88f6e to
df7f0bd
Compare
scagood
reviewed
Nov 4, 2024
MichaelDeBoey
force-pushed
the
extract-test-globals-correctly
branch
from
df7f0bd to
0d81ddc
Compare
scagood
approved these changes
Nov 5, 2024
@scagood You mean the types that aren't used? As I said I my OP, I kept them for future reference if we ever need them |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've put the non-exported classes in here as well in case we would ever need them
Probably closes #377
Out of scope for this PR as the class isn't exported, but I was wondering how we would handle the "extends
node:stream'sReadableclass" in the case ofTestsStream🤔TestsStreamis only created in16.19.0&18.9.0, butnode:stream'sReadableclass is already existing way earlier.For functionality that's present in
node:stream'sReadableclass before16.19.0&18.9.0we should just use16.19.0&18.9.0inTestsStreamI think?And for functionality that's added to
node:stream'sReadableclass after16.19.0&18.9.0, we just keep the same values I think?Since I wasn't sure, I kept the original value as a comment
Unfortunately this means that we would need to find some way of noticing ourselves that we need to update
TestsStreamwhenever we updatenode:stream'sReadableclassWe will have the same problem with
TestContext'sassertproperty and all top-level functions fromnode:assert