Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP 8.4 compatibility (dependency to localheinz/diff causes issue) #1390

Closed
simonschaufi opened this issue Oct 17, 2024 · 2 comments · Fixed by #1377
Closed

PHP 8.4 compatibility (dependency to localheinz/diff causes issue) #1390

simonschaufi opened this issue Oct 17, 2024 · 2 comments · Fixed by #1377
Assignees

Comments

@simonschaufi
Copy link

simonschaufi commented Oct 17, 2024

Steps required to reproduce the problem

  1. Run composer normalize under PHP 8.4

Expected Result

  • No deprecation warnings

Actual Result

Deprecation Notice: Localheinz\Diff\Differ::diff(): Implicitly marking parameter $lcs as nullable is deprecated, the explicit nullable type must be used instead in /vendor/localheinz/diff/src/Differ.php:85
Deprecation Notice: Localheinz\Diff\Differ::diffToArray(): Implicitly marking parameter $lcs as nullable is deprecated, the explicit nullable type must be used instead in /vendor/localheinz/diff/src/Differ.php:111
@Chris53897
Copy link

Should be resolved now

@simonschaufi
Copy link
Author

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants