Fix overriding ActionController::Live with test_behaviour when not test mode.

[gurix]

Including ActionController::TestCase::Behavior overrides ActionController::Live#new_controller_thread as discussed on rails/rails#31200. This issue also affects any production mode as the include is not done just in test mode.

This pull request separates production code from test code by query the environment. I am not satisfied by this solution. In the future we should think about separating even more by monkey patching in tests only.

[coveralls]

Coverage remained the same at 99.353% when pulling 7db6ba8 on gurix:master into 6279fb1 on enriclluelles:master.

[coveralls]

Coverage remained the same at 99.353% when pulling 7db6ba8 on gurix:master into 6279fb1 on enriclluelles:master.

[coveralls]

Coverage remained the same at 99.353% when pulling 7db6ba8 on gurix:master into 6279fb1 on enriclluelles:master.

[coveralls]

Coverage remained the same at 99.353% when pulling 7db6ba8 on gurix:master into 6279fb1 on enriclluelles:master.

[coveralls]

Coverage remained the same at 99.353% when pulling 7db6ba8 on gurix:master into 6279fb1 on enriclluelles:master.

[tagliala]

@gurix sorry for the very late reply

If this is the best solution at the moment, we will go for it

Please give me a couple of days

[tagliala]

@gurix a couple of questions:

1. Any chance of adding a failing test case?
2. How does rails conditionally load TestCase in test environment?

I can see that in production environment ActionController::TestCase is loaded:

$ rails c production
Running via Spring preloader in process 10786
Loading production environment (Rails 5.2.0.rc2)
2.5.0 :001 > defined?(ActionController::TestCase)
 => "constant" 

[gurix]

@tagliala Thanks for your response.

1. I have no Idea how to implement a test for that because rails itself having this issue when testing. So every test including ActionController::Live hangs after 10 responses. And testing if it works when not in the test environment does not make any sense as we are by definition in it.

2. Yes, but i guess ActionController::TestCase is loaded somehow before ActionController::Live which then overrides what's in ActionController::TestCase. And what you are doing is load it again and override it with ActionController::TestCase.

As I wrote, i am not very happy with this solution as it is somehow a rails problem done by @tenderlove two years ago. But it is the best fix for the moment. I also wrote him but had no answer til now.

[tagliala]

@gurix thanks

I'm not going to merge this PR because I was working on another branch and I've cherry-picked your commit

[tagliala]

5.6.1 released

Don't worry about the Travis.CI failure, it is because of a rails 5.2 issue with Ruby 2.2.10

[gurix]

Cool, I just updated my broken App with version 5.6.2 and now everything is working fine. Now I can bump my production site to rails 5.1. 🎉💃🏻Thanks for your support.