-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
iOS12 branch is unusable due to Swift4.2-incompatbile PMAlertController #121
Comments
Hey, the pull request is created on PMAlertController :) Edit: PMA is updated :) |
Fixed, going to release it ;) |
@robbiet480, @gorbat-o please when you have time could you please check the release 4.0.0? |
Hey @ennioma So, I tried to remove the branch iOS12 from the podfile and it does not compile cause it is not catching the 4.0.0 version with a pod update
|
I forgot to submit the pod to Cocopods 🤦🏻♂️ |
@ennioma hey |
Yes! @gorbat-o try the version 4.0.1 please |
I might do something wrong I guess.. :/
Is the minimum deployment target changed ? :/ EDIT: I changed my minimum deployment target to ios11 and it works 👍 |
Life is going fast ahead :P |
@ennioma Was there a specific reason to set the deployment target to iOS 11? Most apps with large user bases support the last 2 major iOS versions. I'm gonna need to hack around with the Podspec to get this installed with a deployment target of iOS 10. It doesn't appear like there's anything that required the switch to 11 but I'm probably missing something. |
Hey @robbiet480 I've created the PR #127 only for the releases that will support Xcode 10. Let me know what you think |
🎉 Congrats 🚀 arek (4.0.2) successfully published
|
Currently, PMAlertController is spewing a lot of errors during build on a Swift4.2 project due to Swift 4.2 changes. I've gotten around this by doing the following:
s.dependency
in the PodspecThe text was updated successfully, but these errors were encountered: