fix(ses): reject unsupported lockdownOptions mathTaming + dateTaming

[kumavis]

This is a breaking change.

support for lockdown options mathTaming and dateTaming were removed so long ago I'm having trouble finding a proper reference (edit: july 2020 #372). Since these options don't do anything, lockdown should fail when these options are specified.

For LavaMoat, we were surprised to find they were being provided to lockdown, but had no effect. Any other unrecognized lockdown options are rejected.

Here is a non-breaking change that adds a warning when the options are specified #2584

[kumavis]

@kriskowal unrelated playwright install issue (?)

[kriskowal]

@kriskowal unrelated playwright install issue (?)

Definitely unrelated. We saw this once before when one of the browsers shifted underneath us. I reran the job and it persisted. It’s not a required job.

[kriskowal]

This is a breaking change. We should use a console warning instead, and leave a note somewhere for behaviors we would change to errors in the next-breaking version, maybe next year.

[kumavis]

@kriskowal whats the process for queueing breaking changes?

[boneskull]

Is it unacceptable to just ignore the options?

EDIT:

My personal opinion is that this should not throw, because shipping a breaking change should be a last resort.

[kriskowal]

@kriskowal whats the process for queueing breaking changes?

We do not have one yet, but I think a new label next-major is in order. The queue is not empty (__options__ on Compartment options bag, deprecated module descriptor formats, &c.)

Closing in favor of #2584