Search for .mem in same directory as Node script #4936
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This seems to be a common source of issues when trying to run optimized code with separate .js.mem from Node.js, while not being in the same working directory (in particular, got hit by this nyself while implementing rust-lang/rust#39490).
It was possible to workaround this and set search path using
Module.memoryInitializerPrefixURL
since 7e9e24, but I think it makes sense to have a nice default for 90% of cases too, which would be to search for.js.mem
file in the same directory as.js
itself.