Output dir support wip #180 #396
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Cannot add test. With the current master, duplicating the first fs test breaks the following tests. Need help with that. Not sure what code complete is. |
Codecov Report
|
tkh44
reviewed
Oct 13, 2017
| @@ -32,13 +38,34 @@ describe('babel plugin fs', () => { | |||
| babelrc: false | |||
| }) | |||
| expect(fs.existsSync).toBeCalledWith(cssFilename) | |||
| expect(mkdirp.sync).not.toBeCalledWith() | |||
| expect(touch.sync).toBeCalledWith(cssFilename) | |||
| expect(fs.writeFileSync).toHaveBeenCalled() | |||
| expect(fs.writeFileSync.mock.calls[0][0]).toBe(cssFilename) | |||
There was a problem hiding this comment.
In order to use the fs mock, you need to increment the array index like these.
There was a problem hiding this comment.
There was a problem hiding this comment.
That's a mistake. I wanted to check it wasn't called with anything, because the mkdirp should only be used when the outputDir property is provided.
|
Test are running fine on my local machine, not sure what's with the failing checks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
#180
Why:
Prevents polluting src tree when preparing production / static builds.
How:
By saving the optional key
outputDirin the babel plugin state and doing extra stuff if that key is present at the end of the babel transformation.Checklist: