Specify a size for URL previews #13461
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is kinda hard to test on the fly, nobody wants to URL-preview localhost
turt2live
approved these changes
Apr 30, 2020
|
I've poked @nadonomy for feedback |
|
@foldleft rather than resizing the asset currently being used by the opengraph tags, can we instead just use this asset? |
|
@nadonomy that's fine, but is the size okay? The linked issue is about making the image smaller. |
|
Should be fine— the issue is the aspect ratio rather than the absolute size. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is kinda hard to test on the fly, nobody wants to URL-preview localhost
Fixes: #12014
Best only close the ticket once confirmed in prod