Windows NSIS One-Click Setup Launched while App already running in background

[dharders]

• Version: 5.19.0

• Target: win32 NSIS One-click

If the installer (AppName Setup x.x.x.exe) is launched while an application instance of AppName.exe is already running, a dialog appears stating "AppName is running. Click OK to close it and continue with install". This is good and expected behaviour.

If you click OK, then the app instance is automatically closed and setup continues. Good again. However, if the user clicks "cancel" or closes the dialog then the user is left with a hung install progress bar that is never going to move.

Expected Behaviour:

Clicking cancel (or closing the dialog) should automatically close the Setup instance also.

P.S. Keep up the great work!

[dharders]

Found a simple fix!

templates/nsis/allowOnlyOneInstallerInstace.nsh#L29

Change: Abort

To: Quit

cc @develar

[justijndepover]

The link you provided is not working anymore. Can you show us a working fix?

[dharders]

@justijndepover here's an updated working link

But really you shouldn't need it as it was already fixed. If you're still experiencing this in the latest version maybe create a new issue ?

[justijndepover]

The problem occured on an old project of mine. The error occures when someone tries to install my application on a new device. So there isn't an instance running in the background. Can you verify that this is the same problem?