Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(command): refactor messaging handler #4204

Merged
merged 2 commits into from
Oct 22, 2022
Merged

refactor(command): refactor messaging handler #4204

merged 2 commits into from
Oct 22, 2022

Conversation

chr1shung
Copy link

  • update external commandQueryHandler function signature
  • remove duplicate error message

Signed-off-by: Chris Hung chris@iotechsys.com

If your build fails due to your commit message not passing the build checks, please review the guidelines here: /~https://github.com/edgexfoundry/edgex-go/blob/main/.github/Contributing.md

PR Checklist

Please check if your PR fulfills the following requirements:

  • I am not introducing a breaking change (if you are, flag in conventional commit message with BREAKING CHANGE: describing the break)
  • I am not introducing a new dependency (add notes below if you are)
  • I have added unit tests for the new feature or bug fix (if not, why?)
  • I have fully tested (add details below) this the new feature or bug fix (if not, why?)
  • I have opened a PR for the related docs change (if not, why?)

Testing Instructions

New Dependency Instructions (If applicable)

@chr1shung
Copy link
Author

recheck

@lenny-goodell
Copy link
Member

Note that the snap build is currently failing on all PRs. Snap team is aware and says we can merge without it passing.

lenny-goodell
lenny-goodell previously approved these changes Oct 20, 2022
View reviewed changes
Copy link
Member

@lenny-goodell lenny-goodell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lenny-goodell
Copy link
Member

@hahattan , some failed tests.

refactor(command): refactor messaging handler
885ee4a 
- update external commandQueryHandler function signature
- remove duplicate error message

Signed-off-by: Chris Hung <chris@iotechsys.com>
refactor(command): update internal command response log
81e2e70 
Signed-off-by: Chris Hung <chris@iotechsys.com>
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

lenny-goodell
lenny-goodell approved these changes Oct 22, 2022
View reviewed changes
Copy link
Member

@lenny-goodell lenny-goodell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lenny-goodell lenny-goodell merged commit 2325198 into edgexfoundry:main Oct 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lenny-goodell lenny-goodell lenny-goodell approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chr1shung @lenny-goodell