Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Enhance autodiscovery to better support multiple instances of same device service #1444

Merged

Conversation

lenny-goodell
Copy link
Member

@lenny-goodell lenny-goodell commented May 2, 2023

closes #1437

If your build fails due to your commit message not passing the build checks, please review the guidelines here: /~https://github.com/edgexfoundry/device-sdk-go/blob/main/.github/Contributing.md

PR Checklist

Please check if your PR fulfills the following requirements:

  • I am not introducing a breaking change (if you are, flag in conventional commit message with BREAKING CHANGE: describing the break)
  • I am not introducing a new dependency (add notes below if you are)
  • I have added unit tests for the new feature or bug fix (if not, why?)
  • I have fully tested (add details below) this the new feature or bug fix (if not, why?)
  • I have opened a PR for the related docs change (if not, why?)

Testing Instructions

TBD

New Dependency Instructions (If applicable)

…ame device service.

closes edgexfoundry#1437

Signed-off-by: Leonard Goodell <leonard.goodell@intel.com>
cloudxxx8
cloudxxx8 previously approved these changes May 5, 2023
Copy link
Member

@cloudxxx8 cloudxxx8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Leonard Goodell <leonard.goodell@intel.com>
@lenny-goodell lenny-goodell requested a review from cloudxxx8 May 8, 2023 20:58
@lenny-goodell lenny-goodell marked this pull request as ready for review May 8, 2023 20:58
@lenny-goodell
Copy link
Member Author

@cloudxxx8 , I reworked the System Events subscribe so it subscribes properly when service has an instance name. Please re-review. THX!

Copy link
Member

@cloudxxx8 cloudxxx8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lenny-goodell lenny-goodell merged commit d75af8d into edgexfoundry:main May 9, 2023
@lenny-goodell lenny-goodell deleted the auto-discovered-device-owner branch May 9, 2023 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Service Name in Provision Watcher prevents multiple instance of service using same Provision Watcher
2 participants