Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Stop AutoEvents if the Device is locked #1027

Merged
merged 2 commits into from
Oct 12, 2021

Conversation

cloudxxx8
Copy link
Member

@cloudxxx8 cloudxxx8 commented Oct 6, 2021

When the Device Update callback is executed, stop AutoEvents if the
adminState of the Device becomes LOCKED.
Fix #1008

Signed-off-by: Cloud Tsai cloudxxx8@gmail.com

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

If your build fails due to your commit message not passing the build checks, please review the guidelines here: /~https://github.com/edgexfoundry/device-sdk-c/blob/master/.github/CONTRIBUTING.md

What is the current behavior?

When the Device Update callback is executed, always restart the AutoEvents.

Issue Number:

Fix #1008

What is the new behavior?

When the Device Update callback is executed, stop AutoEvents if the adminState of the Device becomes LOCKED.

Does this PR introduce a breaking change?

  • Yes
  • No

New Imports

  • Yes
  • No

Specific Instructions

Other information

When the Device Update callback is executed, stop AutoEvents if the
adminState of the Device becomes LOCKED.
Fix edgexfoundry#1008

Signed-off-by: Cloud Tsai <cloudxxx8@gmail.com>
Copy link
Member

@lenny-goodell lenny-goodell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cloudxxx8 cloudxxx8 merged commit c02be29 into edgexfoundry:main Oct 12, 2021
@cloudxxx8 cloudxxx8 deleted the issue-1008 branch October 12, 2021 00:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AutoEvents won't stop when device in in LOCKED or DOWN state
2 participants