Skip to content

Commit

Permalink
fable: Instantiate missing Number<signed char>
Browse files Browse the repository at this point in the history
As it turns out, specially for char, the following is true:

    char != unsigned char
    char != signed char

Which is surprising to me. I hope that this is compatible with
other compilers, otherwise this change will need some secondary
patching.
  • Loading branch information
cassava committed Dec 7, 2023
1 parent 88a92dc commit 475edfc
Showing 1 changed file with 5 additions and 4 deletions.
9 changes: 5 additions & 4 deletions fable/src/fable/schema/number.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -33,14 +33,15 @@ namespace fable {
namespace schema {

template class Number<char>;
template class Number<signed char>;
template class Number<unsigned char>;
template class Number<short>;
template class Number<signed short>;
template class Number<unsigned short>;
template class Number<int>;
template class Number<signed int>;
template class Number<unsigned int>;
template class Number<long int>;
template class Number<signed long int>;
template class Number<unsigned long int>;
template class Number<long long int>;
template class Number<signed long long int>;
template class Number<unsigned long long int>;
template class Number<float>;
template class Number<double>;
Expand Down

0 comments on commit 475edfc

Please sign in to comment.