Adapts Che to new dashboard next image #18332

sleshchenko · 2020-11-11T09:36:23Z

What does this PR do?

This PR adapts Che to new dashboard next image which includes the existing dashboard, that's done in che-incubator/che-dashboard-next#71
So, Che Server as previously copies resources from Dashboard + Dashboard Next resources.
Helm chart now serves the dashboard next from a separate deployment.

Screenshot/screencast of this PR

What issues does this PR fix or reference?

It's a kind of prerequisites for #17647

How to test this PR?

For Che Server image testing, just run Che in any way and check that dashboard and dashboard next are available.

For helm chart, see more:

helm chart tested configurations

SingleUser Single host

export CHART_DIR=/home/sleshche/projects/che/deploy/kubernetes/helm/che
helm upgrade --install che \
  --force \
  --namespace che \
  --set global.cheDomain=$(minikube ip).nip.io \
  --set global.ingressDomain=$(minikube ip).nip.io \
  --set cheImage=sleshchenko/che-server:no-dashboards \
  --set global.serverStrategy=single-host \
  --set global.tls.useSelfSignedCerts=true \
  -f ${CHART_DIR}/values/tls.yaml \
  ${CHART_DIR}

Multiuser Single host gateway

export CHART_DIR=/home/sleshche/projects/che/deploy/kubernetes/helm/che
helm upgrade --install che \
  --force \
  --namespace che \
  --set global.cheDomain=$(minikube ip).nip.io \
  --set global.ingressDomain=$(minikube ip).nip.io \
  --set cheImage=sleshchenko/che-server:no-dashboards \
  --set global.tls.useSelfSignedCerts=true \
  --set global.serverStrategy=single-host \
  --set cheSinglehostGateway.deploy=true \
  --set global.singleHostExposure=gateway \
  -f ${CHART_DIR}/values/tls.yaml \
  -f ${CHART_DIR}/values/multi-user.yaml \
  ${CHART_DIR}

Multiuser Multihost

export CHART_DIR=/home/sleshche/projects/che/deploy/kubernetes/helm/che
helm upgrade --install che \
  --force \
  --namespace che \
  --set global.cheDomain=$(minikube ip).nip.io \
  --set global.ingressDomain=$(minikube ip).nip.io \
  --set cheImage=sleshchenko/che-server:no-dashboards \
  --set global.serverStrategy=multi-host \
  --set global.tls.useSelfSignedCerts=true \
  -f ${CHART_DIR}/values/tls.yaml \
  -f ${CHART_DIR}/values/multi-user.yaml \
  ${CHART_DIR}

PR Checklist

As the author of this Pull Request I made sure that:

Reviewers

Reviewers, please comment how you tested the PR when approving it.

akurinnoy

LGTM

che-bot · 2020-11-11T09:43:25Z

❌ E2E Happy path tests failed ❗

See Details

Jenkins job
test report
logs and configs
Happy path tests DevFile
image: maxura/che-server:18332

Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1)

Use comment "[crw-ci-test]" to rerun happy path E2E test.
Use comment "[crw-ci-test --rebuild]" to re-build the images and rerun happy path E2E test.

sleshchenko · 2020-11-11T09:47:14Z

rebased against master to try to fix happy path test

che-bot · 2020-11-11T10:16:01Z

❌ E2E Happy path tests failed ❗

See Details

Jenkins job
test report
logs and configs
Happy path tests DevFile
image: maxura/che-server:18332

Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1)

Use comment "[crw-ci-test]" to rerun happy path E2E test.
Use comment "[crw-ci-test --rebuild]" to re-build the images and rerun happy path E2E test.

che-bot · 2020-11-12T08:20:46Z

❌ E2E Happy path tests failed ❗

See Details

Jenkins job
test report
logs and configs
Happy path tests DevFile
image: maxura/che-server:18332

Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1)

Use comment "[crw-ci-test]" to rerun happy path E2E test.
Use comment "[crw-ci-test --rebuild]" to re-build the images and rerun happy path E2E test.

sleshchenko · 2020-11-13T07:04:49Z

crw-ci-test

che-bot · 2020-11-18T12:23:01Z

✅ E2E Happy path tests succeed 🎉

See Details

Jenkins job
logs and configs
Happy path tests DevFile
image: maxura/che-server:18332

Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1)

Use comment "[crw-ci-test]" to rerun happy path E2E test.
Use comment "[crw-ci-test --rebuild]" to re-build the images and rerun happy path E2E test.

sleshchenko · 2020-11-19T09:06:05Z

Is WIP to avoid merging in 7.22

sleshchenko · 2020-11-23T15:23:11Z

Rebased against master to make sure everything works before merging

che-bot · 2020-11-23T15:40:03Z

✅ E2E Happy path tests succeed 🎉

See Details

Jenkins job
logs and configs
Happy path tests DevFile
image: maxura/che-server:18332

Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1)

Use comment "[crw-ci-test]" to rerun happy path E2E test.
Use comment "[crw-ci-test --rebuild]" to re-build the images and rerun happy path E2E test.

sleshchenko · 2020-11-23T16:23:34Z

Build fails with [�[1;31mERROR�[m] Tests run: 2, Failures: 1, Errors: 0, Skipped: 1, Time elapsed: 0.756 s <<< FAILURE! - in org.eclipse.che.plugin.typescript.dto.TypeScriptDTOGeneratorMojoITest
Probably I need to wait a bit to get syncs flashed after release

che-bot · 2020-11-24T11:45:42Z

❌ E2E Happy path tests failed ❗

See Details

Jenkins job
test report
logs and configs
Happy path tests DevFile
image: maxura/che-server:18332

Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1)

Use comment "[crw-ci-test]" to rerun happy path E2E test.
Use comment "[crw-ci-test --rebuild]" to re-build the images and rerun happy path E2E test.

sleshchenko · 2020-11-24T12:08:19Z

[crw-ci-test]

ScrewTSW · 2020-11-24T12:22:25Z

[ci-build]

che-bot · 2020-11-24T12:28:31Z

❌ E2E Happy path tests failed ❗

See Details

Jenkins job
test report
logs and configs
Happy path tests DevFile
image: maxura/che-server:18332

Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1)

Use comment "[crw-ci-test]" to rerun happy path E2E test.
Use comment "[crw-ci-test --rebuild]" to re-build the images and rerun happy path E2E test.

ScrewTSW · 2020-11-24T14:12:14Z

[crw-ci-test --rebuild]

che-bot · 2020-11-24T14:46:21Z

❌ E2E Happy path tests failed ❗

See Details

Jenkins job
test report
logs and configs
Happy path tests DevFile
image: maxura/che-server:18332

Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1)

Use comment "[crw-ci-test]" to rerun happy path E2E test.
Use comment "[crw-ci-test --rebuild]" to re-build the images and rerun happy path E2E test.

sleshchenko · 2020-11-24T14:54:02Z

[crw-ci-test --rebuild]

ScrewTSW · 2020-11-24T15:02:38Z

Interesting, it's still trying to look for spring-petclinic-2.3.0.BUILD-SNAPSHOT.jar instead of spring-petclinic-2.4.0.BUILD-SNAPSHOT.jar even though the changes were merged into upstream.

@sleshchenko could you try to rebase your PR based on the latest master of eclipse/che and force-push the branch?

ScrewTSW · 2020-11-24T15:20:24Z

[ci-build]

che-bot · 2020-11-24T15:23:20Z

✅ E2E Happy path tests succeed 🎉

See Details

Jenkins job
logs and configs
Happy path tests DevFile
image: maxura/che-server:18332

Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1)

Use comment "[crw-ci-test]" to rerun happy path E2E test.
Use comment "[crw-ci-test --rebuild]" to re-build the images and rerun happy path E2E test.

sleshchenko requested review from benoitf and nickboldt as code owners November 11, 2020 09:36

sleshchenko self-assigned this Nov 11, 2020

sleshchenko requested review from akurinnoy and mkuznyetsov November 11, 2020 09:36

che-bot added status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. kind/task Internal things, technical debt, and to-do tasks to be performed. labels Nov 11, 2020

akurinnoy approved these changes Nov 11, 2020

View reviewed changes

sleshchenko force-pushed the dashboard-next branch from 4e645fc to 60c3296 Compare November 11, 2020 09:47

sleshchenko mentioned this pull request Nov 11, 2020

Rework dashboard next image to be based on the current dashboard che-incubator/che-dashboard-next#71

Merged

sleshchenko force-pushed the dashboard-next branch from 60c3296 to 277f9e4 Compare November 12, 2020 08:14

sleshchenko force-pushed the dashboard-next branch from 277f9e4 to 563e0d0 Compare November 18, 2020 12:05

sleshchenko added this to the 7.23 milestone Nov 19, 2020

sleshchenko changed the title ~~Adapts Che to new dashboard next image~~ WIP Adapts Che to new dashboard next image Nov 19, 2020

sleshchenko changed the title ~~WIP Adapts Che to new dashboard next image~~ Adapts Che to new dashboard next image Nov 20, 2020

sleshchenko requested review from tolusha and skabashnyuk November 20, 2020 10:56

skabashnyuk approved these changes Nov 20, 2020

View reviewed changes

sleshchenko force-pushed the dashboard-next branch from 563e0d0 to 14a22c2 Compare November 23, 2020 15:22

sleshchenko force-pushed the dashboard-next branch from 14a22c2 to 750d99b Compare November 24, 2020 11:29

This comment has been minimized.

Sign in to view

sleshchenko and others added 2 commits November 24, 2020 17:07

Serve dashboard next from separate deployment with helm chart

37f6520

Copy dashboard next resources from new location

d5564ac

sleshchenko force-pushed the dashboard-next branch from 750d99b to d5564ac Compare November 24, 2020 15:07

sleshchenko merged commit c1353d3 into master Nov 24, 2020

sleshchenko deleted the dashboard-next branch November 24, 2020 15:46

che-bot removed the status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. label Nov 24, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Adapts Che to new dashboard next image #18332

Adapts Che to new dashboard next image #18332

sleshchenko commented Nov 11, 2020 •

edited

Loading

akurinnoy left a comment

che-bot commented Nov 11, 2020

sleshchenko commented Nov 11, 2020

che-bot commented Nov 11, 2020

che-bot commented Nov 12, 2020

sleshchenko commented Nov 13, 2020

che-bot commented Nov 18, 2020

sleshchenko commented Nov 19, 2020

sleshchenko commented Nov 23, 2020

che-bot commented Nov 23, 2020

sleshchenko commented Nov 23, 2020

che-bot commented Nov 24, 2020

This comment has been minimized.

sleshchenko commented Nov 24, 2020

ScrewTSW commented Nov 24, 2020

che-bot commented Nov 24, 2020

ScrewTSW commented Nov 24, 2020

che-bot commented Nov 24, 2020

sleshchenko commented Nov 24, 2020

ScrewTSW commented Nov 24, 2020 •

edited

Loading

ScrewTSW commented Nov 24, 2020

che-bot commented Nov 24, 2020

Adapts Che to new dashboard next image #18332

Adapts Che to new dashboard next image #18332

Conversation

sleshchenko commented Nov 11, 2020 • edited Loading

What does this PR do?

Screenshot/screencast of this PR

What issues does this PR fix or reference?

How to test this PR?

PR Checklist

Reviewers

akurinnoy left a comment

Choose a reason for hiding this comment

che-bot commented Nov 11, 2020

sleshchenko commented Nov 11, 2020

che-bot commented Nov 11, 2020

che-bot commented Nov 12, 2020

sleshchenko commented Nov 13, 2020

che-bot commented Nov 18, 2020

sleshchenko commented Nov 19, 2020

sleshchenko commented Nov 23, 2020

che-bot commented Nov 23, 2020

sleshchenko commented Nov 23, 2020

che-bot commented Nov 24, 2020

This comment has been minimized.

sleshchenko commented Nov 24, 2020

ScrewTSW commented Nov 24, 2020

che-bot commented Nov 24, 2020

ScrewTSW commented Nov 24, 2020

che-bot commented Nov 24, 2020

sleshchenko commented Nov 24, 2020

ScrewTSW commented Nov 24, 2020 • edited Loading

ScrewTSW commented Nov 24, 2020

che-bot commented Nov 24, 2020

sleshchenko commented Nov 11, 2020 •

edited

Loading

ScrewTSW commented Nov 24, 2020 •

edited

Loading