You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
ScmService should be a single source of the whole scm state, git extension should populate it and provide git specific view instead of duplicating this state partially and trying to sync it.
For right now repositories state is duplicated several times:
GitContribution.dirtyResporitories duplicating GitRepositoryProvider.allRepositories which duplicating ScmService.repositories
GitRepositoryProvider should be a git specific facade to ScmService. Handling of ScmProvider should be moved to GitRepositoryProvider instead of keeping allRepositories and GitContribution.dirtyResporitories.
The text was updated successfully, but these errors were encountered:
akosyakov
added
git
issues related to git
quality
issues related to code and application quality
scm
issues related to the source control manager
labels
May 29, 2019
ScmService
should be a single source of the whole scm state, git extension should populate it and provide git specific view instead of duplicating this state partially and trying to sync it.For right now repositories state is duplicated several times:
GitContribution.dirtyResporitories
duplicatingGitRepositoryProvider.allRepositories
which duplicatingScmService.repositories
GitRepositoryProvider.selectedRepository
duplicatingScmService.selectedRepository
GitRepositoryProvider
should be a git specific facade toScmService
. Handling ofScmProvider
should be moved toGitRepositoryProvider
instead of keeping allRepositories andGitContribution.dirtyResporitories
.The text was updated successfully, but these errors were encountered: