-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor SlnFileFactory + slnf #46002
Open
edvilme
wants to merge
11
commits into
dotnet:release/9.0.3xx
Choose a base branch
from
edvilme:edvilme-slnf
base: release/9.0.3xx
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
Area-CLI
untriaged
Request triage from a team member
labels
Jan 15, 2025
edvilme
changed the title
Use SlnFileFactory to support slnf
Centralize support for slnf
Jan 15, 2025
Some notes/comments
|
Forgind
reviewed
Jan 15, 2025
This was referenced Jan 16, 2025
This was referenced Jan 16, 2025
MiYanni
approved these changes
Jan 17, 2025
Rebased as this was targeting release/9.0.2xx instead of release/9.0.3xx |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates
SlnFileFactory
to provide a centralized way of finding, listing and parsing solution files using vs-solutionpersistence, including solution filter files (.slnf)This includes tentative support for
dotnet sln file.slnf list