Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor SlnFileFactory + slnf #46002

Open
wants to merge 11 commits into
base: release/9.0.3xx
Choose a base branch
from

Conversation

edvilme
Copy link
Member

@edvilme edvilme commented Jan 15, 2025

Updates SlnFileFactory to provide a centralized way of finding, listing and parsing solution files using vs-solutionpersistence, including solution filter files (.slnf)

This includes tentative support for dotnet sln file.slnf list
image

@dotnet-issue-labeler dotnet-issue-labeler bot added Area-CLI untriaged Request triage from a team member labels Jan 15, 2025
@edvilme edvilme changed the title Use SlnFileFactory to support slnf Centralize support for slnf Jan 15, 2025
@edvilme edvilme requested a review from a team January 15, 2025 21:26
@edvilme edvilme marked this pull request as ready for review January 15, 2025 21:26
@edvilme edvilme changed the title Centralize support for slnf Refactor SlnFileFactory + slnf Jan 15, 2025
@edvilme
Copy link
Member Author

edvilme commented Jan 15, 2025

Some notes/comments

src/Cli/dotnet/SlnFileFactory.cs Outdated Show resolved Hide resolved
src/Cli/dotnet/SlnFileFactory.cs Show resolved Hide resolved
src/Cli/dotnet/SlnFileFactory.cs Outdated Show resolved Hide resolved
src/Cli/dotnet/SlnFileFactory.cs Show resolved Hide resolved
src/Cli/dotnet/SlnFileFactory.cs Outdated Show resolved Hide resolved
src/Cli/dotnet/SlnFileFactory.cs Show resolved Hide resolved
src/Cli/dotnet/commands/dotnet-sln/list/Program.cs Outdated Show resolved Hide resolved
src/Cli/dotnet/SlnFileFactory.cs Show resolved Hide resolved
src/Cli/dotnet/SlnFileFactory.cs Show resolved Hide resolved
@edvilme edvilme changed the base branch from release/9.0.2xx to release/9.0.3xx January 17, 2025 18:19
@edvilme
Copy link
Member Author

edvilme commented Jan 17, 2025

Rebased as this was targeting release/9.0.2xx instead of release/9.0.3xx

@edvilme edvilme requested a review from MiYanni January 17, 2025 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-CLI untriaged Request triage from a team member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants