Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sort object properties optimally in emitted config binding gen logic #92594

Open
layomia opened this issue Sep 25, 2023 · 2 comments
Open

Sort object properties optimally in emitted config binding gen logic #92594

layomia opened this issue Sep 25, 2023 · 2 comments
Labels
area-Extensions-Configuration help wanted [up-for-grabs] Good issue for external contributors tenet-performance Performance related issue
Milestone
10.0.0

Comments

@layomia
Copy link
Contributor

layomia commented Sep 25, 2023

Per @eerhardt in #89587.

ints are pretty common in config. It might make sense to keep this near the top of the check, so we don't have to check a bunch of other (less common) types first.

@dotnet/area-extensions-configuration.
@layomia layomia added this to the 9.0.0 milestone Sep 25, 2023
@layomia layomia self-assigned this Sep 25, 2023
@ghost
Copy link

ghost commented Sep 25, 2023

Tagging subscribers to this area: @dotnet/area-extensions-configuration
See info in area-owners.md if you want to be subscribed.

Issue Details

Per @eerhardt in #89587.

ints are pretty common in config. It might make sense to keep this near the top of the check, so we don't have to check a bunch of other (less common) types first.

@dotnet/area-extensions-configuration.

Author: layomia
Assignees: layomia
Labels:

tenet-performance, area-Extensions-Configuration
Milestone: 9.0.0

@layomia layomia mentioned this issue Sep 25, 2023
Merged
@layomia layomia removed their assignment Sep 25, 2023
@layomia layomia added the help wanted [up-for-grabs] Good issue for external contributors label Sep 25, 2023
@ericstj ericstj modified the milestones: 9.0.0, 10.0.0 Aug 6, 2024
@ericstj
Copy link
Member

ericstj commented Aug 6, 2024

This is a nice-to-have perf improvement. Moving out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-Extensions-Configuration help wanted [up-for-grabs] Good issue for external contributors tenet-performance Performance related issue
Projects
None yet
Milestone
10.0.0
Development

No branches or pull requests
2 participants
@ericstj @layomia