LibraryImport cannot handle a property named "System"

[mstefarov]

Description

If there is a property named "System" in scope where LibraryImport is used, the generated code will fail to build with error CS0120.

This is probably caused by ambiguity between "System" namespace and "System" property. Perhaps generated code should prefix types with global::?

Reproduction Steps

using System;
using System.Runtime.InteropServices;

namespace ClassLibrary1;

public partial class Class1
{
    public int System => GetSystem(out _);

    [LibraryImport("foo.dll")]
    private static partial int GetSystem(out IntPtr handle);
}

Expected behavior

Generated code builds successfully.

Actual behavior

Build fails with an error in generated code:

LibraryImports.g.cs(10,13,10,19): error CS0120: An object reference is required for the non-static field, method, or property 'Class1.System'

Regression?

No response

Known Workarounds

No response

Configuration

net7.0 on Windows 10 x64, using VS 17.7.0

Other information

No response

[ghost]

Tagging subscribers to this area: @dotnet/interop-contrib
See info in area-owners.md if you want to be subscribed.

Issue Details

---

Description

If there is a property named "System" in scope where LibraryImport is used, the generated code will fail to build with error CS0120.

This is probably caused by ambiguity between "System" namespace and "System" property. Perhaps generated code should prefix types with global::?

Reproduction Steps

using System;
using System.Runtime.InteropServices;

namespace ClassLibrary1;

public partial class Class1
{
    public int System => GetSystem(out _);

    [LibraryImport("foo.dll")]
    private static partial int GetSystem(out IntPtr handle);
}

Expected behavior

Generated code builds successfully.

Actual behavior

Build fails with an error in generated code:

LibraryImports.g.cs(10,13,10,19): error CS0120: An object reference is required for the non-static field, method, or property 'Class1.System'

Regression?

No response

Known Workarounds

No response

Configuration

net7.0 on Windows 10 x64, using VS 17.7.0

Other information

No response

Author:	mstefarov
Assignees:	-
Labels:	area-System.Runtime.InteropServices
Milestone:	-

[AaronRobinsonMSFT]

@jkoritzinsky Are we missing a global:: prefix in some case?

[jtschuster]

Looks like in SkipInit and the DllImportAttribute application we're missing it.

[AaronRobinsonMSFT]

I assume this is an easy fix.

[dotMorten]

I assume this is an easy fix.

I just looked at the PR 😬 #Jinx