Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

source-build TargetRid and SourceBuildNonPortable don't flow through to the native scripts #74577

Closed
tmds opened this issue Aug 25, 2022 · 0 comments · Fixed by #74504
Closed

Comments

@tmds
Copy link
Member

tmds commented Aug 25, 2022

These parameters don't flow through to the native scripts.

The issue is masked because the native __DistroRid default value matches the default TargetRid.

If you set TargetRid to something other than __DistroRid, the build fails.

@ghost ghost added the untriaged New issue has not been triaged by the area owner label Aug 25, 2022
@ghost ghost added the in-pr There is an active PR which will close this issue when it is merged label Aug 25, 2022
@NikolaMilosavljevic NikolaMilosavljevic removed the untriaged New issue has not been triaged by the area owner label Sep 7, 2022
@ghost ghost removed the in-pr There is an active PR which will close this issue when it is merged label Sep 28, 2022
@ghost ghost locked as resolved and limited conversation to collaborators Oct 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants