Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crossgen2 should publish with NativeAOT at the beginning of the build #71557

Closed
agocke opened this issue Jul 1, 2022 · 2 comments
Closed

Crossgen2 should publish with NativeAOT at the beginning of the build #71557

agocke opened this issue Jul 1, 2022 · 2 comments

Comments

@agocke
Copy link
Member

agocke commented Jul 1, 2022

Right now we publish Crossgen2 with NativeAOT at the end of the build for publishing. This uses the "live" AOT compiler we just built. But if we compile at the end of the build, we don't get any testing of the results when we run crossgen2 during the build.

We should probably support two publish modes: "live" and "package". When we use "package" we can use the compiler from the SDK or from the Microsoft.Dotnet.ILCompiler package. These modes can probably be controlled by a property that we set somewhere during the build.

Since we probably don't want to AOT crossgen2 every time we build it for inner-loop development, we'll also need an intermediate project that signals that we want to AOT the crossgen2 project. This might be the existing crossgen-corelib project.

@ghost ghost added the untriaged New issue has not been triaged by the area owner label Jul 1, 2022
@agocke agocke added area-NativeAOT-coreclr and removed untriaged New issue has not been triaged by the area owner area-crossgen2-coreclr labels Jul 1, 2022
@agocke agocke added this to the 7.0.0 milestone Jul 1, 2022
@agocke agocke added this to AppModel Jul 1, 2022
@MichalStrehovsky MichalStrehovsky modified the milestones: 7.0.0, 8.0.0 Aug 12, 2022
@MichalStrehovsky
Copy link
Member

I tried doing a live build approach (instead of LKG) here: #63571

@agocke
Copy link
Member Author

agocke commented Jul 11, 2023

Thought about this a bit more and I'm not convinced it's the right thing to do. Some benefits, some drawbacks. I'm going to close this out and we can reopen if we find other reasons to do it.

@agocke agocke closed this as completed Jul 11, 2023
@ghost ghost locked as resolved and limited conversation to collaborators Aug 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Archived in project
Development

No branches or pull requests

2 participants