costed index range building #2104
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
max-hoffman
force-pushed
the
max/costed-index-scan
branch
from
de5d0f1 to
98924b6
Compare
max-hoffman
force-pushed
the
max/costed-index-range-building
branch
from
6dd07bb to
f40ccbe
Compare
fulghum
approved these changes
Nov 7, 2023
| @@ -200,7 +208,7 @@ func (c *indexCoster) updateBest(s sql.Statistic, filters sql.FastIntSet) { | |||
| // flatten converts a filter into a tree of indexFilter, a format designed | |||
| // to make costing index scans easier. We return the root of the new tree | |||
| // and a conjunction of filters that cannot be pushed into index scans. | |||
| func (c *indexCoster) flatten(e sql.Expression) (indexFilter, sql.Expression) { | |||
| func (c *indexCoster) flatten(e sql.Expression, invert bool) (indexFilter, sql.Expression) { | |||
There was a problem hiding this comment.
Is invert needed? I was trying to figure out what it means, but didn't see it referenced anywhere in the function. Seems like this might just be an artifact of the changes being split up into multiple change sets though.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.