Refactor col defaults #1932
Closed
Refactor col defaults #1932
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…] ...) Verified matched MySQL behavior, which differs from documentation.
Use EvaluateCondition for conditions in join statements
Add support for json_contains_path()
Fixed case sensitivity bugs in various statements
zachmu
approved these changes
Aug 15, 2023
| parsed, err := planbuilder.Parse(ctx, e.Analyzer.Catalog, query) | ||
| if err != nil { | ||
| err2 := clearAutocommitTransaction(ctx) | ||
| if err2 != nil { | ||
| err = errors.Wrap(err, "unable to clear autocommit transaction: "+err2.Error()) |
There was a problem hiding this comment.
Better to return an err from here directly rather than letting happen by code outside the block
Same comment on the lines below
| @@ -362,14 +363,15 @@ func injectBindVarsAndPrepare( | |||
| ) (string, map[string]*querypb.BindVariable, error) { | |||
| parsed, err := sqlparser.Parse(q) | |||
| if err != nil { | |||
| return q, nil, err | |||
| return q, nil, sql.ErrSyntaxError.New(err) | |||
There was a problem hiding this comment.
Why is this wrapping necessary here?
There was a problem hiding this comment.
Some error tests expected this errors.Kind. I could also change the tests
| @@ -178,6 +178,11 @@ type PrimaryKeySchemaTarget interface { | |||
| WithPrimaryKeySchema(schema PrimaryKeySchema) (Node, error) | |||
| } | |||
|
|
|||
| type DynamicColumnsTable interface { | |||
There was a problem hiding this comment.
Needs a comment, same with method names
There was a problem hiding this comment.
Should also give this a boolean HasDynamicColumns() bool to make it clearer as a marker interface
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dolt column defaults work differently than GMS's. This inlines resolving column defaults during name resolution to get closer to Dolt's desired behavior.