Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add create table comment on table clause to table spec #2296

Closed
Allam76 opened this issue Jan 28, 2024 · 1 comment
Closed

add create table comment on table clause to table spec #2296

Allam76 opened this issue Jan 28, 2024 · 1 comment

Comments

@Allam76
Copy link

Allam76 commented Jan 28, 2024

In the current version comments on columns are passed on to the create statement api. Comment on the table itself is not. It is parsed in the AST but not carried over to the table spec.

Could it be possible to implement that? I guess a string map to the table spec structure in ddl.go should do it,

Example sql from google:

CREATE TABLE example (
  example_column INT COMMENT "This is an example column",
  another_column VARCHAR COMMENT "One more column"
) COMMENT="This is a comment about table";

It is the last comment "This is a comment about table" that is missing
Many thanks
Martin

@fulghum
Copy link
Contributor

fulghum commented Jan 31, 2024

Hi @Allam76, thank you for reaching out with this enhancement request. I moved this issue over to the dolt repo issue queue, since we want to support table level comments in Dolt, and that work will require support in GMS, as well as additional changes in Dolt. I just posted an update this morning with some progress, and I'm hoping to have the initial support out for review later today.

I'm going to resolve this issue in the GMS issue queue, since we're tracking the issue in the Dolt issue queue, and that captures the same work.

Thank you for the enhancement request! We're making active progress on it, so keep an eye out on dolthub/dolt#7416 for more updates.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants