Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dolt CLI should always use the pager when results are more than one page. #505

Closed
zachmu opened this issue Mar 31, 2020 · 3 comments
Closed
Labels
cli enhancement New feature or request

Comments

@zachmu
Copy link
Member

zachmu commented Mar 31, 2020

Also, compatibility with rlwrap would be nice to have.

@timsehn timsehn added enhancement New feature or request cli labels Aug 30, 2022
@timsehn timsehn changed the title Page SQL results in shell when they are more than a page Dolt CLI should always use the pager when results are more than one page. Apr 14, 2023
@timsehn
Copy link
Contributor

timsehn commented Apr 14, 2023

Places to use the pager:

  1. SQL Results
  2. --help text

Add more as we discover them here.

@nicktobey
Copy link
Contributor

Many failure modes for commands print the help text, even though --help wasn't passed in. Using the pager there could be potentially unexpected though, since the intended command shouldn't print the help string.

@timsehn
Copy link
Contributor

timsehn commented Apr 15, 2024

I've noticed we do this now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cli enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants