update(katana): estimate fee on deploy account tx #639
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kariy here's that change was talking about, most likely I'm doing something wrong... Estimate fee endpoint returns following error:
|
kariy
reviewed
Jul 12, 2023
Comment on lines
+109
to
+111
| let mut inner_vec = calldata.to_vec(); | ||
| inner_vec.push(class_hash); | ||
| inner_vec.push(contract_address_salt); |
There was a problem hiding this comment.
its actually should be:
[class_hash, salt, constructor_calldata]based on starknet-rs impl... which is different from the starknet docs
|
@broody Do you mind if i takeover this PR? |
Yes plzzz! |
|
Closing this in favour of #644 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.