-
Notifications
You must be signed in to change notification settings - Fork 18.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add experimental Docker Stack CLI commands #23522
Conversation
@dnephin where can we read up on this feature? |
@duglin I'm going to try and write a doc page today, sorry for the delay! |
Can we have |
Signed-off-by: Daniel Nephin <dnephin@docker.com>
@mlaventure done |
networkSet := make(map[string]bool) | ||
for _, service := range services { | ||
for _, network := range service.Networks { | ||
networkSet[network] = true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can't we just append those in the networks []string
variable from the get go here?
I'm not sure what is the benefit of going through an intermediate map first.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Scratch that, I read the function name afterwards :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ya, I don't know if there is a better way to do this in go.
LGTM (IANAM) Only nitpick I've got is:
we have no other code with the above style as we don't enforce the 80 columns rule |
Signed-off-by: Arnaud Porterie (icecrime) <arnaud.porterie@docker.com>
Added some docs in #23544. |
LGTM 👍 |
Mush better with some docs thanks @icecrime LGTM |
LGTM moving to docs |
So @thaJeztah is on a plane, and this is experimental, soooooooo... 😇 |
Add experimental Docker Stack CLI commands
Adds experimental stack commands for deploying a bundle