Remove deprecated -f flag on docker tag #23090

yongtang · 2016-05-29T15:24:32Z

The -f flag on docker tag has been deprecated in docker 1.10 and is expected to be removed in docker 1.12.
This fix removed the -f flag on docker tag and also updated deprecated.md.

- Description for the changelog

The deprecated -f flag on docker tag has been removed.

NOTE: A separate pull request for engine-api has been opened to cover the related changes:
docker/engine-api#239

Signed-off-by: Yong Tang yong.tang.github@outlook.com

thaJeztah · 2016-05-29T15:36:32Z

thanks! can you check the bash/zsh completion scripts as well? not sure if they still contain this flag

thaJeztah · 2016-05-29T15:38:19Z

also /cc @dnephin in case your PR needs to be updated

yongtang · 2016-05-29T15:46:02Z

Thanks @thaJeztah. I checked contrib/completion/bash/docker and contrib/completion/zsh/_docker, didn't find the reference of -f/-force for docker tag.

albers · 2016-05-29T16:11:51Z

@thaJeztah -f was removed from the completions in #19642, so we are clean here.

thaJeztah · 2016-05-29T16:42:56Z

That's for checking! (Was typing on my phone, so wasn't able to check myself)

LGTM

thaJeztah · 2016-05-30T22:53:09Z

@yongtang docker/engine-api#239 was merged, so you can update the vendored engine-API files

yongtang · 2016-05-30T23:06:49Z

Thanks @thaJeztah the pull request has been updated to include the engine-api changes. Let me know if there are any issues.

thaJeztah · 2016-05-31T15:39:02Z

thanks! LGTM

vdemeester · 2016-06-01T14:46:26Z

LGTM 🐼

vdemeester · 2016-06-01T15:09:40Z

Moving this to docs-review. Looks like at least /~https://github.com/docker/docker/blob/master/docs/reference/api/docker_remote_api_v1.24.md#tag-an-image-into-a-repository needs some updates

yongtang · 2016-06-01T15:26:46Z

Thanks @vdemeester. The related docs docker_remote_api_v1.24.md and docker_remote_api.md has been updated to include the changes in this pull request.

thaJeztah · 2016-06-01T15:37:08Z

docs/reference/api/docker_remote_api.md

@@ -122,6 +122,7 @@ This section lists each version from latest to oldest.  Each listing includes a
 * `GET /events` now supports a `reload` event that is emitted when the daemon configuration is reloaded.
 * `GET /events` now supports filtering by daemon name or ID.
 * `GET /images/json` now supports filters `since` and `before`.
+* `POST /images/(name)/tag` now removes deprecated query parameter `force`.


Thinking of better wording for this, perhaps;

* `POST /images/(name)/tag` no longer has a `force` query parameter.

thaJeztah · 2016-06-01T15:38:32Z

One small suggestion, but LGTM otherwise

yongtang · 2016-06-01T15:45:10Z

Thanks @thaJeztah the pull request has been updated.

This fix updates engine-api to 6facb3f3c38717b8f618dcedc4c8ce20d1bfc61e. This fix is related to moby#23090. Signed-off-by: Yong Tang <yong.tang.github@outlook.com>

The -f flag on docker tag has been deprecated in docker 1.10 and is expected to be removed in docker 1.12. This fix removed the -f flag on docker tag and also updated deprecated.md. NOTE: A separate pull request for engine-api has been opened to cover the related changes. Signed-off-by: Yong Tang <yong.tang.github@outlook.com>

…er tag`. This fix updates remote API docs for the removal of deprecated `force` in `docker tag`. Signed-off-by: Yong Tang <yong.tang.github@outlook.com>

thaJeztah · 2016-06-01T19:23:40Z

LGTM

ping @vdemeester @SvenDowideit PTAL

vdemeester · 2016-06-01T19:29:23Z

LGTM 👼

chriskuehl · 2016-07-11T00:14:24Z

It seems that there's no backwards-compatible way to force-tag images now that works with Docker versions prior to 1.10 (released only 5 months ago). I've opened #24494 for discussion; please consider waiting to drop this flag, as this will make it very difficult to migrate large Docker deployments to 1.12.

Docker removed a flag that broke Packer. Docker versions >1.12 fail with force set to true. Packer issue tracking it: hashicorp/packer#3771 PR that broke us: moby/moby#23090 Change-Id: I6f544e5d8353e997d2560fe96e7ae545761c2173 Signed-off-by: Daniel Farrell <dfarrell@redhat.com>

GordonTheTurtle added the status/0-triage label May 29, 2016

yongtang force-pushed the 05292016-remove-deprecated-docker-tag-f branch from 9678774 to 09dfe60 Compare May 29, 2016 16:09

thaJeztah added status/2-code-review impact/changelog impact/deprecation and removed status/0-triage labels May 29, 2016

thaJeztah added this to the 1.12.0 milestone May 29, 2016

yongtang mentioned this pull request May 29, 2016

Remove deprecated -f flag on docker tag docker/engine-api#239

Merged

yongtang force-pushed the 05292016-remove-deprecated-docker-tag-f branch from 09dfe60 to 2242a78 Compare May 29, 2016 17:22

yongtang force-pushed the 05292016-remove-deprecated-docker-tag-f branch from 2242a78 to 61d7436 Compare May 30, 2016 23:02

yongtang force-pushed the 05292016-remove-deprecated-docker-tag-f branch from 61d7436 to 8b2189a Compare May 30, 2016 23:14

yongtang mentioned this pull request Jun 1, 2016

Add --limit option to docker search #23107

Merged

vdemeester added status/3-docs-review and removed status/2-code-review labels Jun 1, 2016

thaJeztah reviewed Jun 1, 2016
View reviewed changes

yongtang force-pushed the 05292016-remove-deprecated-docker-tag-f branch from 3aec367 to 2766118 Compare June 1, 2016 15:44

yongtang added 3 commits June 1, 2016 09:44

Vendor engine-api to 6facb3f3c38717b8f618dcedc4c8ce20d1bfc61e

1dab9af

This fix updates engine-api to 6facb3f3c38717b8f618dcedc4c8ce20d1bfc61e. This fix is related to moby#23090. Signed-off-by: Yong Tang <yong.tang.github@outlook.com>

Update remote API docs for the removal of deprecated force in `dock…

7b08941

…er tag`. This fix updates remote API docs for the removal of deprecated `force` in `docker tag`. Signed-off-by: Yong Tang <yong.tang.github@outlook.com>

yongtang force-pushed the 05292016-remove-deprecated-docker-tag-f branch from 2766118 to 7b08941 Compare June 1, 2016 16:45

mlaventure mentioned this pull request Jun 1, 2016

Add support for multiple runtimes #22983

Merged

vdemeester merged commit cbccb19 into moby:master Jun 1, 2016

yongtang deleted the 05292016-remove-deprecated-docker-tag-f branch June 2, 2016 14:18

jimmyxian mentioned this pull request Jun 6, 2016

Keep track of the missing API in Swarm docker-archive/classicswarm#2333

Closed

23 tasks

chriskuehl mentioned this pull request Jul 11, 2016

[1.12rc3] No backwards-compatible way to force-tag images? #24494

Closed

thaJeztah mentioned this pull request Jul 16, 2016

Add dummy '--force' flag for backwards compatibility #24721

Closed

jglick added a commit to jenkinsci/workflow-aggregator-plugin that referenced this pull request Aug 8, 2016

Removing -f option from tag as per moby/moby#23090.

ddf8140

jglick added a commit to jenkinsci/docker-workflow-plugin that referenced this pull request Aug 8, 2016

Removing -f option from tag as per moby/moby#23090.

75f183a

jglick added a commit to jenkinsci/github-branch-source-plugin that referenced this pull request Aug 8, 2016

Removing -f option from tag as per moby/moby#23090.

07b49b9

jglick added a commit to jenkinsci/parallel-test-executor-plugin that referenced this pull request Aug 8, 2016

Removing -f option from tag as per moby/moby#23090.

1ee760b

dfarrell07 mentioned this pull request Aug 10, 2016

docker -f deprecation -- now removed hashicorp/packer#3771

Closed

heitorsilva mentioned this pull request Sep 14, 2016

Support for Docker >= 1.12 open-lambda/open-lambda#10

Closed

ixdy mentioned this pull request Sep 21, 2016

Docker no longer supports -f for the tag command kubernetes/test-infra#631

Merged

paulcichonski mentioned this pull request Nov 5, 2016

publish command broken in docker 1.12 cisco/elsy#25

Closed

coolljt0725 mentioned this pull request Nov 10, 2016

docker tag command usability #28204

Closed

thaJeztah mentioned this pull request Dec 14, 2016

Removal of the -f flags in docker tag break compatibility with server 1.9.x #29410

Closed

guessi mentioned this pull request Feb 15, 2017

Conditional ignore force flag for docker-tag hashicorp/packer#4560

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Remove deprecated -f flag on docker tag #23090

Remove deprecated -f flag on docker tag #23090

yongtang commented May 29, 2016 •

edited

Loading

thaJeztah commented May 29, 2016

thaJeztah commented May 29, 2016

yongtang commented May 29, 2016

albers commented May 29, 2016

thaJeztah commented May 29, 2016

thaJeztah commented May 30, 2016

yongtang commented May 30, 2016

thaJeztah commented May 31, 2016

vdemeester commented Jun 1, 2016

vdemeester commented Jun 1, 2016

yongtang commented Jun 1, 2016

thaJeztah Jun 1, 2016

thaJeztah commented Jun 1, 2016

yongtang commented Jun 1, 2016

thaJeztah commented Jun 1, 2016

vdemeester commented Jun 1, 2016

chriskuehl commented Jul 11, 2016

Remove deprecated -f flag on docker tag #23090

Remove deprecated -f flag on docker tag #23090

Conversation

yongtang commented May 29, 2016 • edited Loading

thaJeztah commented May 29, 2016

thaJeztah commented May 29, 2016

yongtang commented May 29, 2016

albers commented May 29, 2016

thaJeztah commented May 29, 2016

thaJeztah commented May 30, 2016

yongtang commented May 30, 2016

thaJeztah commented May 31, 2016

vdemeester commented Jun 1, 2016

vdemeester commented Jun 1, 2016

yongtang commented Jun 1, 2016

thaJeztah Jun 1, 2016

Choose a reason for hiding this comment

thaJeztah commented Jun 1, 2016

yongtang commented Jun 1, 2016

thaJeztah commented Jun 1, 2016

vdemeester commented Jun 1, 2016

chriskuehl commented Jul 11, 2016

yongtang commented May 29, 2016 •

edited

Loading