Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

key lost in this line when not exactly devided #185

Open
happynoom opened this issue Oct 15, 2021 · 0 comments
Open

key lost in this line when not exactly devided #185

happynoom opened this issue Oct 15, 2021 · 0 comments

Comments

@happynoom
Copy link

happynoom commented Oct 15, 2021

ps-lite/src/postoffice.cc

Lines 172 to 176 in 08fb534

for (int i = 0; i < num_servers_; ++i) {
server_key_ranges_.push_back(Range(
kMaxKey / num_servers_ * i,
kMaxKey / num_servers_ * (i+1)));
}

this may cause key lost when kMaxKey not exactly divided for the last range end

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant