Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bugfix]adapt networkx version to run the tutorial #937

Closed
wants to merge 2 commits into from

Conversation

burness
Copy link

@burness burness commented Oct 18, 2019

new networkx wouldn't support the syntax dgl used

Hi, DGLer

I'm a new dgl developer, I build a Docker Image according the docker scripts. I found a error when I run the tutorial
image
It was caused by the versions of networkx as show in https://networkx.github.io/documentation/stable/release/migration_guide_from_1.x_to_2.0.html. Unfortunately network-2.3 wouldn't support the syntax that the dgl used. So we may specify the version of networkx or change the all networkx api in the dgl code.

@classicsong
Copy link
Contributor

classicsong commented Oct 18, 2019

The current docker image (built from the dockerfile) is only for CI-test.
I think it is much better to add version notification for corresponding tutorial docs and the example README, but not the dockerfile.

BTW @burness It is better to lunch an issue first and then propose your fix.

@burness
Copy link
Author

burness commented Oct 18, 2019

😃 😃 😃 @classicsong

@classicsong
Copy link
Contributor

The current docker image (built from the dockerfile) is only for CI-test.
I think it is much better to add version notification for corresponding tutorial docs and the example README, but not the dockerfile.

BTW @burness It is better to lunch an issue first and then propose your fix.

Same problem also for setup.py. see #948 for more details

@burness
Copy link
Author

burness commented Oct 24, 2019

I will review the dgl python code with networkx this weekend. If the time is allowed, I will help to update your code with the new version NetworkX api @classicsong @mufeili

@mufeili
Copy link
Member

mufeili commented Oct 27, 2019

@burness Awesome, thanks for the help.

@jermainewang jermainewang mentioned this pull request Oct 28, 2019
32 tasks
@jermainewang
Copy link
Member

@burness #949 has changed all the deprecated G.selfloop_edges to functional nx.selfloop_edges(G). This API is compatible with all networkx version after v2.1. Thus, we don't need to upgrade the depending networkx version of DGL anymore. Thanks for the fix and report of this problem.

@burness
Copy link
Author

burness commented Oct 30, 2019

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants